-
Notifications
You must be signed in to change notification settings - Fork 427
[feat] Add rectangular hover area tracking for queue overlay #6894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Running jobs now show cancel button at all times (always visible) - Cancel/delete buttons use destructive red styling by default - Changed pending job icon from clock to loader-circle with spin animation - Fixed icon buttons to be square (size-6) instead of rectangular - Added TODO comment for future declarative button config system 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Uses useMouse + useElementBounding from VueUse to detect hover over the entire rectangular bounding box of the queue area (actionbar + overlay). This approach is needed because QueueProgressOverlay has pointer-events-none on its wrapper, which would create "holes" in hover detection with standard mouseenter/mouseleave events. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
🎭 Playwright Test Results⏰ Completed at: 11/24/2025, 09:17:49 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/24/2025, 09:07:30 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
|
Even if design says we need it, we can probably replace this with dom/css gymnastics |
Summary
Adds hover detection over the entire rectangular bounding box of the queue area (actionbar + QueueProgressOverlay combined).
Implementation
Uses
useMouse+useElementBoundingfrom VueUse to compute whether the mouse position is within the element's bounds:This approach is needed because
QueueProgressOverlayhaspointer-events-noneon its wrapper, which would create "holes" in hover detection with standardmouseenter/mouseleaveevents.Status
⏳ Waiting for design confirmation on whether we need the strict rectangular hover area tracking, or if standard hover events would suffice.
Depends on
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito