Skip to content

Polish: Make the clickable area for the slots more forgiving #7084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2025
Merged

Polish: Make the clickable area for the slots more forgiving #7084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6ac561
Polish: Make the clickable area for the slots more forgiving
DrJKL Dec 1, 2025
da6d6d8
[automated] Update test expectations
invalid-email-address Dec 2, 2025
72c0313
test: use force to ignore the pseudoelement catching the drop otherwise
DrJKL Dec 2, 2025
566dc95
test: two more dragTo
DrJKL Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ async function connectSlots(
const fromLoc = slotLocator(page, from.nodeId, from.index, false)
const toLoc = slotLocator(page, to.nodeId, to.index, true)
await expectVisibleAll(fromLoc, toLoc)
await fromLoc.dragTo(toLoc)
await fromLoc.dragTo(toLoc, { force: true })
await nextFrame()
}

Expand Down Expand Up @@ -183,7 +183,7 @@ test.describe('Vue Node Link Interaction', () => {
const inputSlot = slotLocator(comfyPage.page, clipNode.id, 0, true)
await expectVisibleAll(outputSlot, inputSlot)

await outputSlot.dragTo(inputSlot)
await outputSlot.dragTo(inputSlot, { force: true })
await comfyPage.nextFrame()

expect(await samplerOutput.getLinkCount()).toBe(0)
Expand All @@ -210,7 +210,7 @@ test.describe('Vue Node Link Interaction', () => {
const inputSlot = slotLocator(comfyPage.page, samplerNode.id, 3, true)
await expectVisibleAll(outputSlot, inputSlot)

await outputSlot.dragTo(inputSlot)
await outputSlot.dragTo(inputSlot, { force: true })
await comfyPage.nextFrame()

expect(await samplerOutput.getLinkCount()).toBe(0)
Expand Down
Binary file modified ...oad/uploadWidgets.spec.ts-snapshots/vue-nodes-upload-widgets-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion src/renderer/extensions/vueNodes/components/SlotConnectionDot.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ defineExpose({
<template>
<div
:class="
cn('size-6 flex items-center justify-center group/slot', props.class)
cn(
'after:absolute after:inset-y-0 after:w-5/2 relative size-6 flex items-center justify-center group/slot',
props.class
)
"
>
<div
Expand Down