[Test] Add e2e test on beforeunload bug #721
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
changed the title
christian-byrne
commented
Jan 26, 2025
dosubot
bot
added
size:L
christian-byrne
force-pushed
the
test/beforeunload-confirm
branch
from
db19aed to
d5b7192
Compare
dosubot
bot
added
size:M
Contributor
|
@christian-byrne FYI - put my original ideas on this here. |
webfiltered
reviewed
Feb 14, 2025
Comment on lines
5
to
9
| // Configure installation tests to run serially | ||
| test.describe.configure({ mode: 'serial' }); | ||
|
|
||
| // Use test.describe.serial to ensure tests run in order | ||
| test.describe.serial('Install Wizard', () => { |
Contributor
There was a problem hiding this comment.
Also FYI! Tests are globally serial - via workers: 1 in playwright.config.ts.
christian-byrne
force-pushed
the
test/beforeunload-confirm
branch
from
7423ab9 to
1cc21ab
Compare
dosubot
bot
added
size:M
Contributor
Author
|
Requires #901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test on the issue fixed in Comfy-Org/ComfyUI_frontend#2318 by creating an unsaved workflow and then closing the page with
runBeforeUnloadoption enabled.