Skip to content

Fix Windows DrawingView image rendering so exported/rendered strokes use the correct (round) line caps #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeTraveler merged 2 commits into from
May 11, 2026
Merged

Fix Windows DrawingView image rendering so exported/rendered strokes use the correct (round) line caps #3216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1882c21
Fixed rendering final image of DrawingView using wrong line cap style…
MFinkBK May 11, 2026
975cb57
Renamed defaultCanvasStrokeStyle to roundStartEndCapCanvasStrokeStyle
MFinkBK May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/CommunityToolkit.Maui.Core/Views/DrawingView/Service/DrawingViewService.windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.Numerics;
using Microsoft.Graphics.Canvas;
using Microsoft.Graphics.Canvas.Brushes;
using Microsoft.Graphics.Canvas.Geometry;
using Microsoft.Maui.Platform;
using Windows.Storage.Streams;
using Windows.UI.Input.Inking;
Expand Down Expand Up @@ -155,6 +156,12 @@ static void DrawStrokes(CanvasDrawingSession session,
return offscreen;
}

static readonly CanvasStrokeStyle roundStartEndCapCanvasStrokeStyle = new()
{
StartCap = CanvasCapStyle.Round,
EndCap = CanvasCapStyle.Round,
};

static void DrawInk(this CanvasDrawingSession session, IEnumerable<InkStroke> strokes)
{
foreach (var stroke in strokes)
Expand All @@ -167,7 +174,8 @@ static void DrawInk(this CanvasDrawingSession session, IEnumerable<InkStroke> st
session.DrawLine(
new Vector2((float)currentPoint.X, (float)currentPoint.Y),
new Vector2((float)nextPoint.X, (float)nextPoint.Y),
stroke.DrawingAttributes.Color, (float)stroke.DrawingAttributes.Size.Width);
stroke.DrawingAttributes.Color, (float)stroke.DrawingAttributes.Size.Width,
roundStartEndCapCanvasStrokeStyle);
}
}
}
Expand Down
Loading