Add sun/moon glare intensity settings #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 3 glare settings for clear, rain and thunder weather modes. They are not applying on top of each other, thus giving more control on sun and moon look.
# Conflicts: # shaders/lib/common.glsl # shaders/shaders.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 new options:
Sun / Moonscreen:Sun/Moon Glare IntensityRain / Weatherscreen:Sun/Moon Glare Intensity During RainSun/Moon Glare Intensity During Thunder(works only on Iris)These settings are not applying on top of each other, giving more precise control and ability to disable glare.
Default glare intensity value for clear weather gives almost the same look like on
mainbranch, but for rain and thunder I set the values a little lower compared tomain.I wasn't sure about which branch (
mainorcontribution) should I choose to create PR for. I decided to usemainas it is updated 2 months ago vs 3.