Non-directional shadows in rain and thunder concept #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # shaders/lib/common.glsl # shaders/shaders.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new screen
Rainy WeatherinLightingwith new settings:Non-directional shadows in rain(default:OFF)N/d shadows intensity in rain(default:1.0)Non-directional shadows in thunder(works only on Iris, default:OFF)N/d shadows intensity in thunder(default:1.0)Adding these settings may partially fix #121. I agree with the author of this issue that the shadows in rain shouldn't be so sharp. I was trying to make shadows in rain and thunder more realistic by negating the effect of applying normal shadows. The reasons I called PR a concept are because I'm unsure about the implementation of feature itself and if I did the changes in right place.
Screenshots
All screenshots are done with default preset and settings, rain weather. Only
Non-directional shadows in rainisON.