Update dependencies and use keccak#4
Conversation
|
Thanks @antonio-mendes, that PR worked for me. pip install https://github.com/antonio-mendes/ens-namehash-py/archive/refs/heads/update_library.zip>>> from namehash import namehash
>>> namehash('').hex()
'0000000000000000000000000000000000000000000000000000000000000000'
>>> namehash('foo.eth').hex()
'de9b09fd7c5f901e23a3f19fecc54828e9c848539801e86591bd9801b019f84f'This was with 3.8.13 |
Unfortunately @pipermerriam doesn't seem to be active these days. I've tried e-mailing a few times but got no replies 🥲 |
Any alternative to updating the package? |
Not sure tbh, I can try to reach out to someone at consensys, maybe they'd be able to push this. |
|
My apologies for the radio silence on my part. I'm working to get my copy of this repository transferred to be managed under the Ethereum org's github, at which point the team that manages the rest of the python ethereum libraries will be able to get this merged and released. |
|
Thanks for the update @pipermerriam |
Sounds great, thank you for your work and the update! |
|
Hey @pipermerriam any news on this? |
|
I unfortunately retract my previous statement. Looks like web3.py uses it's own implementation of namehash https://github.com/ethereum/web3.py/blob/f55157195466e6b2554e24c4043d7228b770b4a5/ens/utils.py#L215 And thus, I don't see the Ethereum python team taking ownership of this repository (and I'm no longer going to be maintaining it either). |
The current version fails to build due to an error on the assertion since the function used as is is
sha-256which no longer returns the correct result.To fix this, I updated the lib to use the latest version of
pyhashlib and the correct functionkeccak-256.