Prover/dev small fields

.github/workflows/prover-testing.yml

@@ -41,9 +41,9 @@ jobs:
       working-directory: prover
       run: if [[ -n $(gofmt -l .) ]]; then echo "please run gofmt"; exit 1; fi
     - name: golangci-lint
-      uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 #v6.5.2
+      uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 #v8
       with:
-          version: v1.61.0
+          version: v2.1.6
           working-directory: prover
           args: --timeout=5m
     - name: generated files should not be modified

prover/.gitignore

@@ -0,0 +1,97 @@
+*.pprof
+*.trace
+**/*.DS_Store
+**/.ipynb_checkpoints
+**/__pycache__
+**/debug.log
+**/*.lisp
+lispified
+**/profiling
+!utils/profiling
+**/large_data
+**/*-*-zkProof.json
+**/proving_key.bin
+!**/verifying_key.bin
+**/circuit.bin
+prover/zkevm/arithmetization/zkevm.bin
+
+
+
+# Binaries for programs and plugins
+*.exe
+*.exe~
+*.dll
+*.so
+*.dylib
+__pycache__
+bin/
+vendor/
+.env
+
+# except for single-round bin
+!**/single_round/bin/
+
+!/**/.gitkeep
+
+# Test binary, build with `go test -c`
+*.test
+
+# Output of the go coverage tool, specifically when used with LiteIDE
+*.out
+
+# Coverage
+coverage.html
+*.cov.tmp
+
+# Jetbrains files
+.DS_Store
+.idea
+*.iml
+.idea_modules/
+
+# Build
+build/
+cmake-build-*/
+
+# File-based project format
+*.iws
+*.ipr
+
+# JIRA plugin
+atlassian-ide-plugin.xml
+
+# Go packages and sources:
+.gocache
+
+# Visual Code Studio
+.vscode
+
+!**/**/.gitkeep
+
+# API Doc
+node_modules
+
+# Various logging outputs
+**/*.csv
+**/*.log
+!**/testdata/**/*.csv
+
+# Output of the generator command
+test-data
+
+# Testdata, otherwise that's 400MB of data downloaded
+integration-testing/testdata/prover-requests/
+
+# Authorize the kzg srs folder
+prover-assets/**
+!prover-assets/kzgsrs/**
+
+# Handy for the pprof generated pdf
+**/*.pdf
+
+# For the json, csv and txt files generated while debugging the limitless prover
+# OK to remove eventually.
+protocol/distributed/**/*.json
+protocol/distributed/**/*.txt
+protocol/distributed/**/*.csv
+

prover/.golangci.yml

@@ -1,37 +1,41 @@
+version: "2"
+run:
+  issues-exit-code: 1
 linters:
-  disable-all: true
-  # @alex: we will need to sort out the linters because they take too much time
-  # and memory to run practically since we merged go-corset. We shall revise
-  # our toolset.
+  default: none
   enable:
-    - gofmt
-    # - staticcheck
     - gosec
-    # - gosimple
-    # - govet
     - ineffassign
     - prealloc
-
-run:
-  issues-exit-code: 1
-  # List of build tags, all linters use it.
-  # Default: [].
-  # build-tags:
-
-issues:
-  exclude-dirs:
-    - compressor
-    - zkevm/arithmetization
-  exclude:
-    # Only appears on CI
-    - '.*printf: non-constant format string in call to.*'
-
-linters-settings:
-  staticcheck:
-    checks:
-      - all
-      - '-SA1019' # disable the rule against deprecated code
-      - '-SA1006'
-  gosec:
-    excludes:
-      - G115 # Conversions from int -> uint etc
+  settings:
+    gosec:
+      excludes:
+        - G115
+    staticcheck:
+      checks:
+        - -SA1006
+        - -SA1019
+        - all
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - path: (.+)\.go$
+        text: '.*printf: non-constant format string in call to.*'
+    paths:
+      - compressor
+      - zkevm/arithmetization
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

prover/Makefile

@@ -10,6 +10,32 @@ DARWIN_ARM64_FLAGS := CGO_ENABLED=1 GOOS="linux" GOARCH="arm64"
 # Ensure that we are using go-corset from the monorepo
 GO_CORSET := PATH="${CORSET_ROOT}/bin":$$PATH
 
+# Define the list of Go packages to test
+PACKAGES := \
+	github.com/consensys/linea-monorepo/prover/maths/... \
+  github.com/consensys/linea-monorepo/prover/crypto/... \
+	github.com/consensys/linea-monorepo/prover/symbolic/... \
+  github.com/consensys/linea-monorepo/prover/utils/types/... \
+	github.com/consensys/linea-monorepo/prover/protocol/accessors/... \
+	github.com/consensys/linea-monorepo/prover/protocol/query/... \
+	github.com/consensys/linea-monorepo/prover/protocol/wizard/... \
+	github.com/consensys/linea-monorepo/prover/protocol/wizardutils/... \
+  github.com/consensys/linea-monorepo/prover/protocol/compiler/globalcs/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/innerproduct/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/mpts/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/logderivativesum/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/vortex/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/dummy/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/localcs/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/permutation/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/specialqueries/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/stitchsplit/... \
+	github.com/consensys/linea-monorepo/prover/protocol/compiler/univariates/... \
+  github.com/consensys/linea-monorepo/prover/protocol/dedicated/...\
+  github.com/consensys/linea-monorepo/prover/protocol/compiler/selfrecursion/...\
+
+
+
 # these targets are not defined as depending on source files,
 # so they should be recompiled by default “just in case”.
 .PHONY: \
@@ -28,7 +54,12 @@ GO_CORSET := PATH="${CORSET_ROOT}/bin":$$PATH
 	bin/checker \
 	go-corset \
 	testdata \
+  test-compilers \
+  test \
+  clean
 
+# Default target: runs all tests
+all: test-compilers test
 
 ##
 ## This rule produces the go-corset binary
@@ -131,7 +162,15 @@ lib/compressor-and-shnarf-calculator-local: lib/compressor lib/shnarf_calculator
 ## Run all the unit-tests
 ##
 test:
-	go test -tags debug ./...
+	@echo "Running all Go tests for Linea Monorepo prover packages..."
+	@for pkg in $(PACKAGES); do \
+		echo "--> Running tests for $$pkg"; \
+		go test -tags debug -skip 'Gnark|TestSelfRecursionManyLayersWithSerde' $$pkg || exit 1; \
+	done
+	@echo "All tests completed successfully."
+
+test-compilers:
+	go test -timeout 30s -run ^TestCompilers$$ github.com/consensys/linea-monorepo/prover/protocol/compiler
 
 ##
 ## Run the CI linting
@@ -151,3 +190,9 @@ cgo-flags:
 make update-testdata-for-coordinator:
 	go test -timeout 30m -tags amd64,nocorset -run TestSamples github.com/consensys/linea-monorepo/prover/backend/testing -v
 	cp -f backend/testing/**/*-*-zkProof.json ../testdata/prover/output
+
+# Target to clean Go build cache (optional, but good practice)
+clean:
+	@echo "Cleaning Go build cache..."
+	@go clean -testcache
+	@echo "Go build cache cleaned."

prover/backend/execution/prove.go

@@ -2,13 +2,19 @@ package execution
 
 import (
 	"fmt"
+	"math/rand/v2"
+	"os"
 	"path/filepath"
+	"runtime"
+	"strconv"
+	"time"
 
 	"github.com/consensys/gnark-crypto/ecc"
 	"github.com/consensys/linea-monorepo/prover/circuits"
 	"github.com/consensys/linea-monorepo/prover/circuits/dummy"
 	"github.com/consensys/linea-monorepo/prover/circuits/execution"
 	"github.com/consensys/linea-monorepo/prover/config"
+	"github.com/consensys/linea-monorepo/prover/protocol/serialization"
 	public_input "github.com/consensys/linea-monorepo/prover/public-input"
 	"github.com/consensys/linea-monorepo/prover/utils"
 	"github.com/consensys/linea-monorepo/prover/utils/exit"
@@ -189,6 +195,31 @@ func mustProveAndPass(
 		logrus.Infof("Prover checks passed")
 		return "", ""
 
+	case config.ProverModeEncodeOnly:
+
+		profiling.ProfileTrace("encode-decode-no-circuit", true, false, func() {
+			filepath := "/tmp/wizard-assignment/blob-" + strconv.Itoa(rand.Int()) + ".bin" //nolint:gosec // Ignoring weak randomness error
+
+			encodeOnlyZkEvm := zkevm.EncodeOnlyZkEvm(traces)
+			numChunks := runtime.GOMAXPROCS(0)
+
+			// Serialize the assignment
+			encodingDuration := time.Now()
+			encodeOnlyZkEvm.AssignAndEncodeInChunks(filepath, w.ZkEVM, numChunks)
+
+			// Deserialize the assignment
+			decodingDuration := time.Now()
+			_, errDec := serialization.DeserializeAssignment(filepath, numChunks)
+			if errDec != nil {
+				panic(fmt.Sprintf("Error during deserialization: %v", errDec))
+			}
+			fmt.Printf("[Encoding Summary] took %v sec to encode an assignmente and write it into the files \n", time.Since(encodingDuration).Seconds())
+			fmt.Printf("[Decoding Summary] took %v sec to read the files and decode it into an assignment\n", time.Since(decodingDuration).Seconds())
+		})
+
+		os.Exit(0)
+		return "", ""
+
 	default:
 		panic("not implemented")
 	}

prover/backend/execution/statemanager/worldstate.go

@@ -14,7 +14,7 @@ import (
 const WS_LOCATION = "0x"
 
 var MIMC_CONFIG = &smt.Config{
-	HashFunc: hashtypes.MiMC,
+	HashFunc: hashtypes.Poseidon2,
 	Depth:    40,
 }
 
@@ -46,12 +46,12 @@ func EmptyCodeHash(config *smt.Config) Digest {
 // Returns an EOA account
 func NewEOA(config *smt.Config, nonce int64, balance *big.Int) Account {
 	return types.Account{
-		Nonce:          nonce,
-		Balance:        balance,
-		StorageRoot:    EmptyStorageTrieHash(config), // The eth
-		MimcCodeHash:   EmptyCodeHash(config),
-		KeccakCodeHash: types.AsFullBytes32(LEGACY_KECCAK_EMPTY_CODEHASH),
-		CodeSize:       0,
+		Nonce:             nonce,
+		Balance:           balance,
+		StorageRoot:       EmptyStorageTrieHash(config), // The eth
+		Poseidon2CodeHash: EmptyCodeHash(config),
+		KeccakCodeHash:    types.AsFullBytes32(LEGACY_KECCAK_EMPTY_CODEHASH),
+		CodeSize:          0,
 	}
 }
 
@@ -65,12 +65,12 @@ func NewContractEmptyStorage(
 	codeSize int64,
 ) types.Account {
 	return types.Account{
-		Nonce:          nonce,
-		Balance:        balance,
-		StorageRoot:    EmptyStorageTrieHash(config),
-		MimcCodeHash:   codeHash,
-		KeccakCodeHash: keccakCodeHash,
-		CodeSize:       codeSize,
+		Nonce:             nonce,
+		Balance:           balance,
+		StorageRoot:       EmptyStorageTrieHash(config),
+		Poseidon2CodeHash: codeHash,
+		KeccakCodeHash:    keccakCodeHash,
+		CodeSize:          codeSize,
 	}
 }
 

prover/circuits/aggregation/circuit.go

@@ -74,7 +74,7 @@ func (c *Circuit) Define(api frontend.API) error {
 	}
 
 	// create a lookup table of actual public inputs
-	actualPI := make([]*logderivlookup.Table, (emFr{}).NbLimbs())
+	actualPI := make([]logderivlookup.Table, (emFr{}).NbLimbs())
 	for i := range actualPI {
 		actualPI[i] = logderivlookup.New(api)
 	}

prover/circuits/blobdecompression/v0/compress/internal/io.go

@@ -15,11 +15,11 @@ import (
 // TODO Use std/rangecheck instead
 type RangeChecker struct {
 	api    frontend.API
-	tables map[uint]*logderivlookup.Table
+	tables map[uint]logderivlookup.Table
 }
 
 func NewRangeChecker(api frontend.API) *RangeChecker {
-	return &RangeChecker{api: api, tables: make(map[uint]*logderivlookup.Table)}
+	return &RangeChecker{api: api, tables: make(map[uint]logderivlookup.Table)}
 }
 
 func (r *RangeChecker) AssertLessThan(bound uint, c ...frontend.Variable) {

prover/circuits/blobdecompression/v0/compress/lzss/snark.go

@@ -126,7 +126,7 @@ func Decompress(api frontend.API, c []frontend.Variable, cLength frontend.Variab
 	return dLength, nil
 }
 
-func initAddrTable(api frontend.API, bytes, c []frontend.Variable, wordNbBits int, backrefs []lzss.BackrefType) *logderivlookup.Table {
+func initAddrTable(api frontend.API, bytes, c []frontend.Variable, wordNbBits int, backrefs []lzss.BackrefType) logderivlookup.Table {
 	for i := range backrefs {
 		if backrefs[i].NbBitsLength != backrefs[0].NbBitsLength {
 			panic("all backref types must have the same length size")