Prover/Dev Branch for Keccak Small Field Migration

prover/maths/common/vector/vector_wizard.go

@@ -254,3 +254,25 @@ func PseudoRand(rng *rand.Rand, size int) []field.Element {
 	}
 	return slice
 }
+
+// Zero creates a vector of given size filled with zeroes.
+func Zero(size int) []field.Element {
+	slice := make([]field.Element, size)
+	for i := range slice {
+		slice[i].SetZero()
+	}
+	return slice
+}
+
+// it return a vector of length 'size' where it is one on the given period and zero elsewhere.
+func PeriodicOne(period int, size int) []field.Element {
+	slice := make([]field.Element, size)
+	for i := range slice {
+		if i%period == 0 {
+			slice[i].SetOne()
+		} else {
+			slice[i].SetZero()
+		}
+	}
+	return slice
+}

prover/protocol/dedicated/repeated_pattern_test.go

@@ -6,10 +6,12 @@ import (
 	"github.com/consensys/linea-monorepo/prover/maths/common/smartvectors"
 	"github.com/consensys/linea-monorepo/prover/maths/common/vector"
 	"github.com/consensys/linea-monorepo/prover/maths/field"
+	"github.com/consensys/linea-monorepo/prover/protocol/column/verifiercol"
 	"github.com/consensys/linea-monorepo/prover/protocol/compiler/dummy"
 	"github.com/consensys/linea-monorepo/prover/protocol/ifaces"
 	"github.com/consensys/linea-monorepo/prover/protocol/internal/testtools"
 	"github.com/consensys/linea-monorepo/prover/protocol/wizard"
+	"github.com/stretchr/testify/assert"
 )
 
 // RepeatedPatternTestcase represents a test case for [RepeatedPattern].
@@ -78,3 +80,19 @@ func TestRepeatedPattern(t *testing.T) {
 		})
 	}
 }
+
+func TestRepeatedPatWithVerifCol(t *testing.T) {
+
+	var rp *RepeatedPattern
+	define := func(b *wizard.Builder) {
+		pattern := vector.ForTest(1, 2, 3)
+		rp = NewRepeatedPattern(b.CompiledIOP, 0, pattern, verifiercol.NewConstantCol(field.One(), 32, "active"))
+	}
+	prove := func(run *wizard.ProverRuntime) {
+		rp.Assign(run)
+	}
+	compiled := wizard.Compile(define, dummy.Compile)
+	proof := wizard.Prove(compiled, prove)
+	assert.NoError(t, wizard.Verify(compiled, proof))
+
+}

prover/protocol/wizard/compiled.go

@@ -461,6 +461,9 @@ func (c *CompiledIOP) InsertPrecomputed(name ifaces.ColID, v smartvectors.SmartV
 	// not have the same content but the same name, then we will end up with
 	// a very messed up bug that is hard to track.
 	if c.Columns.Exists(name) {
+		if c.Columns.GetHandle(name).Size() != v.Len() {
+			utils.Panic("Precomputed column %v is registered twice with different sizes (%v and %v)", name, c.Columns.GetHandle(name).Size(), v.Len())
+		}
 		return c.Columns.GetHandle(name)
 	}
 

prover/protocol/wizardutils/evaluation.go

@@ -58,3 +58,15 @@ func RandLinCombColAssignment(run *wizard.ProverRuntime, coinVal fext.Element, h
 	}
 	return smartvectors.NewRegularExt(vWitness)
 }
+
+// LinCombExpr generates a symbolic expression representing a linear combination
+// the expression can be evaluated at point x over the columns hs via [column.EvalExprColumn].
+func LinCombExpr(x int, hs []ifaces.Column) *symbolic.Expression {
+	cols := make([]*symbolic.Expression, len(hs))
+	xExpr := symbolic.NewConstant(int64(x))
+	for c := range cols {
+		cols[c] = ifaces.ColumnAsVariable(hs[c])
+	}
+	expr := symbolic.NewPolyEval(xExpr, cols)
+	return expr
+}