feat: BLS12-381 precompiles glue

.gitignore

@@ -106,7 +106,9 @@ __pycache__/
 /jvm-libs/**/darwin-x86-64
 
 /prover/**/*.csv
-/prover/**/testdata/
+# Exclude files in testdata directories, but not the directories themselves to allow
+# add exceptions (gitignore doesn't permit exceptions when root dir is excluded)
+/prover/**/testdata/*
 # Testdata, otherwise that's 400MB of data downloaded
 /prover/**/integration-testing/testdata/prover-requests/
 /prover/**/vendor/
@@ -147,4 +149,6 @@ __pycache__/
 !prover/**/testdata/**/*.csv
 !prover/**/utils/profiling
 !prover/**/verifying_key.bin
-!/sdk/src/lib/compressor/bin
+!/sdk/src/lib/compressor/bin
+# Allow BLS glue testdata generators
+!prover/zkevm/prover/bls/testdata/*.go

prover/circuits/aggregation/circuit.go

@@ -74,7 +74,7 @@ func (c *Circuit) Define(api frontend.API) error {
 	}
 
 	// create a lookup table of actual public inputs
-	actualPI := make([]*logderivlookup.Table, (emFr{}).NbLimbs())
+	actualPI := make([]logderivlookup.Table, (emFr{}).NbLimbs())
 	for i := range actualPI {
 		actualPI[i] = logderivlookup.New(api)
 	}

prover/circuits/blobdecompression/v0/compress/internal/io.go

@@ -15,11 +15,11 @@ import (
 // TODO Use std/rangecheck instead
 type RangeChecker struct {
 	api    frontend.API
-	tables map[uint]*logderivlookup.Table
+	tables map[uint]logderivlookup.Table
 }
 
 func NewRangeChecker(api frontend.API) *RangeChecker {
-	return &RangeChecker{api: api, tables: make(map[uint]*logderivlookup.Table)}
+	return &RangeChecker{api: api, tables: make(map[uint]logderivlookup.Table)}
 }
 
 func (r *RangeChecker) AssertLessThan(bound uint, c ...frontend.Variable) {
@@ -36,6 +36,7 @@ func (r *RangeChecker) AssertLessThan(bound uint, c ...frontend.Variable) {
 		cRangeTable, ok := r.tables[bound]
 		if !ok {
 			cRangeTable := logderivlookup.New(r.api)
+			r.tables[bound] = cRangeTable
 			for i := uint(0); i < bound; i++ {
 				cRangeTable.Insert(0)
 			}

prover/circuits/blobdecompression/v0/compress/lzss/snark.go

@@ -126,7 +126,7 @@ func Decompress(api frontend.API, c []frontend.Variable, cLength frontend.Variab
 	return dLength, nil
 }
 
-func initAddrTable(api frontend.API, bytes, c []frontend.Variable, wordNbBits int, backrefs []lzss.BackrefType) *logderivlookup.Table {
+func initAddrTable(api frontend.API, bytes, c []frontend.Variable, wordNbBits int, backrefs []lzss.BackrefType) logderivlookup.Table {
 	for i := range backrefs {
 		if backrefs[i].NbBitsLength != backrefs[0].NbBitsLength {
 			panic("all backref types must have the same length size")

prover/circuits/blobdecompression/v1/snark.go

@@ -180,7 +180,7 @@ func CheckBatchesSums(api frontend.API, hasher snarkHash.FieldHasher, nbBatches
 	}
 
 	var (
-		partialSumsT *logderivlookup.Table
+		partialSumsT logderivlookup.Table
 		partialSums  []frontend.Variable
 	)
 	// create a table of claimed sums and prove their correctness as we go through the payload

prover/circuits/internal/utils.go

@@ -40,7 +40,7 @@ func AssertIsLessIf(api frontend.API, cond, a, b frontend.Variable) {
 	api.AssertIsLessOrEqual(a_, b_)
 }
 
-func SliceToTable(api frontend.API, slice []frontend.Variable) *logderivlookup.Table {
+func SliceToTable(api frontend.API, slice []frontend.Variable) logderivlookup.Table {
 	table := logderivlookup.New(api)
 	for i := range slice {
 		table.Insert(slice[i])
@@ -271,7 +271,7 @@ func (s VarSlice) Range(api frontend.API) *Range {
 func Concat(api frontend.API, maxLinearizedLength int, slices ...VarSlice) Slice[frontend.Variable] {
 
 	res := Slice[frontend.Variable]{make([]frontend.Variable, maxLinearizedLength), 0}
-	var outT *logderivlookup.Table
+	var outT logderivlookup.Table
 	{ // hint
 		inLen := 2 * len(slices)
 		for i := range slices {
@@ -414,7 +414,7 @@ func ChecksumSubSlices(api frontend.API, hsh snarkHash.FieldHasher, slice []fron
 		lastElems[i] =
 			plonk.EvaluateExpression(api, e, endpointsR.InRange[i], 0, -1-len(slice), 1, len(slice))
 	}
-	var lastElemsT *logderivlookup.Table
+	var lastElemsT logderivlookup.Table
 	if len(slice) > 1 {
 		lastElemsT = SliceToTable(api, lastElems)
 		lastElemsT.Insert(len(slice)) // in case subEndPoints is tight
@@ -730,7 +730,7 @@ func PartitionSlice(api frontend.API, s []frontend.Variable, selectors []fronten
 		panic(err)
 	}
 
-	subsT := make([]*logderivlookup.Table, len(subs))
+	subsT := make([]logderivlookup.Table, len(subs))
 	for i := range subs {
 		copy(subs[i], subsGlued[:len(subs[i])])
 		subsGlued = subsGlued[len(subs[i]):]

prover/circuits/prove.go

@@ -86,7 +86,8 @@ func ProveCheck(setup *Setup, assignment frontend.Circuit, opts ...any) (plonk.P
 			assignment,
 			assignment,
 			setup.Circuit.Field(),
-			test.WithBackendProverOptions(proverOpts...),
+			// this test engine prover option was no-op before and it was removed
+			// test.WithBackendProverOptions(proverOpts...),
 		)
 		return nil, fmt.Errorf("while running the plonk prover: %w", errDetail)
 	}

prover/crypto/mimc/factories.go

@@ -65,7 +65,7 @@ type externalHashBuilderIFace interface {
 // storeCommitBuilder implements [frontend.Builder], [frontend.Committer] and
 // other methods useful to define a custom external hasher.
 type storeCommitBuilder interface {
-	frontend.Builder
+	frontend.Builder[constraint.U64]
 	frontend.Committer
 	SetKeyValue(key, value any)
 	GetKeyValue(key any) (value any)
@@ -168,8 +168,8 @@ func (h *ExternalHasher) compress(state, block frontend.Variable) frontend.Varia
 // taking part in each claim.
 func NewExternalHasherBuilder(addGateForHashCheck bool) (frontend.NewBuilder, func() [][3][2]int) {
 	rcCols := make(chan [][3][2]int)
-	return func(field *big.Int, config frontend.CompileConfig) (frontend.Builder, error) {
-			b, err := scs.NewBuilder(field, config)
+	return func(field *big.Int, config frontend.CompileConfig) (frontend.Builder[constraint.U64], error) {
+			b, err := scs.NewBuilder[constraint.U64](field, config)
 			if err != nil {
 				return nil, fmt.Errorf("could not create new native builder: %w", err)
 			}