fix: handle localStorage errors in private browsing#298
Merged
pradeeban merged 2 commits intoControlCore-Project:devfrom Feb 18, 2026
Merged
fix: handle localStorage errors in private browsing#298pradeeban merged 2 commits intoControlCore-Project:devfrom
pradeeban merged 2 commits intoControlCore-Project:devfrom
Conversation
avinxshKD
force-pushed
the
fix/localStorage-error-handling
branch
from
7c30dee to
87c79df
Compare
Member
|
Can you say "localStorage" rather than "ls" throughout your code? We still want our code to be human-readable. |
Author
|
@pradeeban done, renamed all three to localStorageGet, localStorageSet, and localStorageRemove nd also double-checked all call sites in the file are updated, no leftover abbreviations. Let me know if any adjustments needed, happy to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapped all localStorage calls in try-catch blocks to prevent app crashes when localStorage is disabled (private browsing, quota exceeded, etc)
Fixes #291
Changes are...
Added error handling wrappers to local-storage-manager.js for all storage operations
Wrapped localStorage calls in fileBrowser.jsx with try-catch blocks
Show toast error with the exception message when storage fails