Fix write() fall-through after ZMQ send#240
Closed
avinxshKD wants to merge 2 commits intoControlCore-Project:devfrom
Closed
Fix write() fall-through after ZMQ send#240avinxshKD wants to merge 2 commits intoControlCore-Project:devfrom
avinxshKD wants to merge 2 commits intoControlCore-Project:devfrom
Conversation
- safe_literal_eval now reads and parses file content instead of always returning default - load_params populates the params map from concore.params file - read() parses list data, extracts simtime from first element, returns rest - Added initval() to parse simtime string and extract data portion - Fixed naming to match codebase style (no underscores in function names) Fixes ControlCore-Project#224
avinxshKD
force-pushed
the
fix-zmq-write-return
branch
from
e3a88c9 to
44e876e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #238
The write() function was missing a return statement after the ZMQ send path, causing execution to fall through into the file-based write logic. This led to redundant file operations after every ZMQ write.
Added return to match the pattern already used in read()