Fix/mkconcore file handle leaks#250
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 11, 2026
Merged
Conversation
Author
|
@pradeeban Hey the test failures are unrelated, they're missing dependencies (click module) in the CI environment. This PR only modifies mkconcore.py file handle management with no logic changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes resource leaks throughout mkconcore.py where file handles weren't properly closed on exception paths.
Changes:
withblockswithblockwithblocks, removed manual.close()callswithblockatexitcleanup as safety net for exception pathsAll bare
open()calls now use context managers. Script handles that span 900+ lines get automatic cleanup viaatexit.register()to handle any edge cases where early exit could leave handles open.Closes #241