music: trial of upstream album art support (PR 1803) - #74
Draft
Coral-coder wants to merge 9 commits into
Draft
Conversation
Add music cover art endpoint, service handling, and app rendering. Includes new music protocol message types, prefs for the feature, and status bar layer support. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Eric Migicovsky <ericmigi@gmail.com>
Rework the music app's album-art mode so the bottom section (times, progress bar and tape) keeps the exact stock layout and code. The cover fills the top, the artist is hidden, and the track title moves beside the tape where it ping-pong scrolls horizontally when it's too long to fit (the layout measurer over-reports width vs what is drawn, so back that out of the scroll range). The clock switches to the large outlined style so it stays legible over the art. Skip the track-change slide animation over art since it fights the art-mode positions, and repaint the whole window on a mode switch to clear moved layers. Default the "Show Album Art" pref to off for a first install. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Eric Migicovsky <ericmigi@gmail.com>
Refine the album-art music screen: - Show the artist name centred and outlined over the bottom of the cover (does not scroll), so it pops against the art. - Replace the ping-pong title scroll with a slower, smoother one-way ticker (a "digital sign") that runs for two passes after a track change then rests showing the start. Draw two copies a measured-width apart so the repeat never overlaps the first. - Outline the clock over the art. - Tighten the title slot and centre it vertically between the progress bar and the bottom of the screen. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Eric Migicovsky <ericmigi@gmail.com>
- Draw the over-art clock white with a black outline (matching the artist) instead of black, so the time reads over the cover. - Use the larger bold clock in the no-art screen too, for consistency. - Nudge the scrolling title up a few px so it sits centred between the progress bar and the bottom of the screen. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Eric Migicovsky <ericmigi@gmail.com>
The music app and endpoint now reference the new album-art music-service functions, so the unit tests need stubs for them: - test_music: stub music_album_art_lock/unlock/is_current, music_is_album_art_supported, music_request_album_art, music_has_now_playing, music_get_now_playing_generation, and shell_prefs_get_music_show_album_art (no art in these tests). - test_music_endpoint: stub gbitmap_format_get_row_size_bytes (referenced by the album-art reassembly path, not exercised here). Refresh the music render goldens for the larger bold clock now used on the no-art screen (no_music is unchanged — it uses a separate window). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Eric Migicovsky <ericmigi@gmail.com>
Watch-pull album art in the music app (upstream coredevices/PebbleOS PR 1803 by ericmigi), grafted onto the fork for on-wrist evaluation. Signed-off-by: Coral Coder <noreply@anthropic.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Keeps the trial branch riding the latest sync (timezone fixes, IMU recovery, moddable 8.3.1) alongside upstream PR 1803's album art. Signed-off-by: Coral Coder <noreply@anthropic.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Brings upstream 2026-08-03 (HRV on obelix) and the nightly-sync hardening into the album-art trial branch. Signed-off-by: Coral Coder <noreply@anthropic.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Coral Coder <noreply@anthropic.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trial branch: upstream coredevices#1803 (album art in the music app, by ericmigi) merged onto current main for on-wrist evaluation. Merged clean, no conflicts. CI artifacts from this PR double as flashable trial builds.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CNRhmmV8Cg7o6U4BBXkkx7
Generated by Claude Code