Skip to content

feat: allow string width input#329

Open
aqilaziz wants to merge 1 commit into
Cordobo:mainfrom
aqilaziz:allow-string-width-input
Open

feat: allow string width input#329
aqilaziz wants to merge 1 commit into
Cordobo:mainfrom
aqilaziz:allow-string-width-input

Conversation

@aqilaziz
Copy link
Copy Markdown

Summary

  • widen the width input type to number | string so strict Angular templates accept values such as width="100%"
  • keep the QRCode renderer config numeric by passing undefined for non-numeric widths
  • update README parameter docs for the new accepted type

Testing

  • npm run lint -- --fix=false
  • npm run ci:build:lib
  • git diff --check

Fixes #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: make the "width" input accept string | number values.

1 participant