Skip to content

Minor #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025
Merged

Minor #60

merged 4 commits into from
May 14, 2025

Conversation

jstarck
Copy link
Contributor

@jstarck jstarck commented May 13, 2025

Fix the binding issue in Sparse2D. Makefiles have been updated to avoid double links to OMP.

@jstarck jstarck self-assigned this May 13, 2025
@sfarrens
Copy link
Member

@jstarck can you please remove any commented lines from the code. Everything is saved in the git history so there is no need to keep lines that don't do anything.

@jstarck
Copy link
Contributor Author

jstarck commented May 14, 2025

Comment lines have been removed. Mutliple library pathes have been added during the compilation, so the dynamic libraries can be found in /usr/lib, /usr/local/lib or bin_path/../lib.

Copy link
Contributor Author

@jstarck jstarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@jstarck jstarck closed this May 14, 2025
@jstarck jstarck reopened this May 14, 2025
Copy link
Contributor Author

@jstarck jstarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@jstarck jstarck merged commit eca99b8 into master May 14, 2025
6 checks passed
@jstarck jstarck deleted the minor branch May 14, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants