Review and fix install scripts #3973

kaanklky · 2023-02-21T19:41:03Z

Also fixes #3970.

kaanklky · 2023-02-22T00:02:56Z

@ar2rsawseen Tested on currently supported OSs; Ubuntu 18, 20, 22 and CentOS/RHEL 7, 8.

kaanklky added 13 commits February 21, 2023 22:08

do not need to handle OS difference here

a020aa6

add path check since we handle installation by countly user now

ebad72f

simplify MongoDB installation

227f9c6

fix indents, if block styles etc

9458d9b

lets keep DIR on the top as usual

95078f9

fix repeating package names

340aed1

keep calling done script at the end

232b1fd

change order of additional repositories

c2c5115

fix pass directory check for github actions

24f9c5a

fix bash parameter pass to if block

5ffb68b

fix owner of service as countly

5d9b59c

fix run supervisord service by countly user

d6d7090

fix MongoDB installation for Ubuntu 22

c9fc5b1

kaanklky requested a review from ar2rsawseen February 22, 2023 00:00

kaanklky mentioned this pull request Feb 22, 2023

Installer on Clean ubuntu fails to install countly correctly #3970

Closed

kaanklky added 4 commits March 1, 2023 01:13

Check by trying to create a file instead of blocking hardcoded paths

1692129

facepalm here

50e0d88

whats matter if you do not exit from the script...

2776412

we do not bypass anything for github actions

083ebcb

ar2rsawseen approved these changes Mar 1, 2023

View reviewed changes

Merge branch 'master' into fix-install-scripts

de1276d

ar2rsawseen merged commit 1618ace into master Mar 1, 2023

Provide feedback