Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint dependencies in workflow #5808

Merged
merged 12 commits into from
Nov 27, 2024
Merged
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ root = true
end_of_line = lf
insert_final_newline = false

[*.{js,html,scss,json}]
[*.{js,html,scss,json,vue}]
indent_style = space
indent_size = 4
27 changes: 20 additions & 7 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,13 @@
{
"files": [
"plugins/content/frontend/content-blocks/**/*.js",
"plugins/journey_engine/frontend/builder/**/*.js"
"plugins/journey_engine/frontend/builder/**/*.js",
"plugins/content/frontend/content-blocks/**/*.vue",
"plugins/journey_engine/frontend/builder/**/*.vue"
],
"plugins": [
"vue",
"@stylistic"
],
"extends": [
"eslint:recommended",
Expand All @@ -151,14 +157,15 @@
"plugin:vue/vue3-recommended"
],
"rules": {
// override these post initial content release, to make them fit with countly convention
"no-console": ["error"],
"@stylistic/quotes": ["error", "single"],
"@stylistic/quote-props": ["error", "as-needed"]
"@stylistic/quote-props": ["error", "as-needed"],
"no-unused-vars": "off",
"vue/no-unused-vars": ["error", {
"ignorePattern": "^_"
}]
},
"plugins": [
"vue",
"@stylistic"
],
"parserOptions": {
"ecmaVersion": 2023,
"sourceType": "module",
Expand Down Expand Up @@ -255,7 +262,13 @@
"plugins/*/frontend/**/*.js",
"plugins/*/extend/**/*.js"
],
"excludedFiles": "plugins/*/frontend/public/**/*.js",
"excludedFiles": [
"plugins/*/frontend/public/**/*.js",
"plugins/content/frontend/content-blocks/**/*.js",
"plugins/journey_engine/frontend/builder/**/*.js",
"plugins/content/frontend/content-blocks/**/*.vue",
"plugins/journey_engine/frontend/builder/**/*.vue"
],
"env": {
"es2023": true,
"node": true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
- name: ESLint
shell: bash
run: |
npm install [email protected]
npm install [email protected] [email protected] @stylistic/[email protected]
npx eslint .

- name: NPM install
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,5 @@ frontend/express/public/stylesheets/vue/clyvue.css.map
log/
log/supervisord/
plugins/plugins.json.*
.sdk
.sdk
dump
Loading