Skip to content

Old UI cleanup #6120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Old UI cleanup #6120

wants to merge 14 commits into from

Conversation

ar2rsawseen
Copy link
Member

No description provided.

@kanwarujjaval kanwarujjaval requested a review from Copilot April 5, 2025 13:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 123 out of 134 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • frontend/express/public/javascripts/dom/dataTables/license-bsd.txt: Language not supported
  • frontend/express/public/javascripts/dom/drop/drop-theme-countly.min.css: Language not supported
  • frontend/express/public/javascripts/dom/jqueryui/jquery.ui.accordion.css: Language not supported
  • frontend/express/public/javascripts/dom/jqueryui/jquery.ui.all.css: Language not supported
  • frontend/express/public/javascripts/dom/jqueryui/jquery.ui.autocomplete.css: Language not supported
  • frontend/express/public/javascripts/dom/jqueryui/jquery.ui.base.css: Language not supported
  • frontend/express/public/javascripts/dom/jqueryui/jquery.ui.button.css: Language not supported
  • frontend/express/public/javascripts/dom/jqueryui/jquery.ui.core.css: Language not supported
  • frontend/express/public/javascripts/dom/jqueryui/jquery.ui.datepicker.css: Language not supported
  • frontend/express/public/javascripts/dom/jqueryui/jquery.ui.dialog.css: Language not supported
  • frontend/express/public/javascripts/dom/jqueryui/jquery.ui.progressbar.css: Language not supported
Comments suppressed due to low confidence (5)

frontend/express/public/javascripts/dom/jquery.sticky.headers.js:1

  • The removal of jquery.sticky.headers.js requires that any feature relying on sticky headers is adequately covered by tests to verify that the UI behaves as expected post-removal.
-(function ($) {

frontend/express/public/javascripts/dom/jquery.form.js:1

  • Ensure that the removal of jquery.form.js is supported by sufficient tests for form submissions to avoid regressions in form behavior.
-/*!

frontend/express/public/javascripts/countly/countly.vue.legacy.js:1

  • The removal of legacy Vue components mandates verifying that no parts of the application still depend on these deprecated functionalities.
-/* global countlyCommon, moment, jQuery*/

frontend/express/public/javascripts/countly/countly.auth.js:298

  • Since the permissionParser function has been removed, confirm that its responsibilities have been fully migrated and that no components are referencing this legacy logic.
-    countlyAuth.permissionParser = function(parent_el, permission_object, permission_sets) {

Gruntfile.js:14

  • The removal of legacy script references from Gruntfile.js is in line with the cleanup; ensure that the build process and any modules relying on these scripts have been updated accordingly.
-                    'frontend/express/public/javascripts/dom/jquery.form.js',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant