Merge pull request #531 from kellyselden/revert_trackNewVersion

Revert "Merge pull request #527 from kellyselden/trackNewVersion"
CrowdStrike · Feb 24, 2025 · 40ee908 · 40ee908
2 parents 6abd764 + e6d81ef
commit 40ee908
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 35 deletions.
diff --git a/src/version.js b/src/version.js
@@ -18,14 +18,8 @@ function trackNewVersion({
       // https://github.com/npm/node-semver/commit/bcab95a966413b978dc1e7bdbcb8f495b63303cd
       range.set[0][0].operator
     ) {
-      let hint = range.raw[0];
-
-      if (hint !== '^' && hint !== '~') {
-        hint = '~';
-      }
-
       // This behaviour can probably be removed in the next major.
-      newRange = `${hint}${newVersion}`;
+      newRange = `~${newVersion}`;
     } else if (
       // NOTE: wildcard range is empty string
       // SEE: https://github.com/npm/node-semver/blob/bcab95a966413b978dc1e7bdbcb8f495b63303cd/test/ranges/to-comparators.js#L10-L12

diff --git a/test/version-test.js b/test/version-test.js
@@ -111,36 +111,14 @@ describe(function() {
       expect(newRange).to.equal('');
     });
 
-    describe('0.0.0', function() {
-      it('preserves ~', function() {
-        let oldRange = '~0.0.0';
-        let newRange = oldRange;
-        let newVersion = '0.0.1';
-
-        newRange = trackNewVersion({ name, oldRange, newRange, newVersion });
-
-        expect(newRange).to.equal('~0.0.1');
-      });
-
-      it('preserves ^', function() {
-        let oldRange = '^0.0.0';
-        let newRange = oldRange;
-        let newVersion = '0.0.1';
-
-        newRange = trackNewVersion({ name, oldRange, newRange, newVersion });
-
-        expect(newRange).to.equal('^0.0.1');
-      });
-
-      it('defaults to ~ when unexpected range', function() {
-        let oldRange = '<0.0.1-0';
-        let newRange = oldRange;
-        let newVersion = '0.0.1';
+    it('uses ~ on major version zero with ^', function() {
+      let oldRange = '^0.0.0';
+      let newRange = oldRange;
+      let newVersion = '0.0.1';
 
-        newRange = trackNewVersion({ name, oldRange, newRange, newVersion });
+      newRange = trackNewVersion({ name, oldRange, newRange, newVersion });
 
-        expect(newRange).to.equal('~0.0.1');
-      });
+      expect(newRange).to.equal('~0.0.1');
     });
 
     it('warns with old range', function() {