Add new Chart Specific Color Palette #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0f857b9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ynotdraw
approved these changes
Feb 7, 2024
nicolechung
approved these changes
Feb 8, 2024
Merged
|
FYI that we're planning to adjust some of these colors slightly, based on designers noticing an issue with sufficient contrast in some cases. Once those are finalized I'll open another PR with the improved colors, and then update this package's version in the apps where it is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to add this new palette to be used in Charts with Toucan. The colors are similar in concept to the existing
graphpalette, but designed to fit alongside each other better as part of Chart visualizations. The new colors being added are:chart-X, Where "X" is a range from 1-10 e.g.chart-1,chart-2chart-disabledchart-neutral-1. Similar in use to thegraph-11color for the graph palette, but with a more descriptive name.chart-neutral-2There is no plan to bring these colors to the mezzanine theme.
There will be a follow-up PR once this is merged to the ember-toucan-styles repo, to make it easier to access these new colors similar to other palettes.