Skip to content

Add pg_hba checksum metric #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 8, 2025
Merged

Add pg_hba checksum metric #4169

merged 10 commits into from
May 8, 2025

Conversation

benjaminjb
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

ccp_pg_hba_checksum metric missing

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

We want OTel metrics to be as close to parity with the postgres_exporter solution as possible; so this PR adds the initial setup and metric query to get
'ccp_pg_hba_checksum', as well as the util function to mark a pg_hba setting as valid.

Other Information:

Issues: [PGO-2395]

tony-landreth
tony-landreth reviewed May 6, 2025
View reviewed changes
tony-landreth
tony-landreth reviewed May 7, 2025
View reviewed changes
tony-landreth
tony-landreth reviewed May 7, 2025
View reviewed changes
tony-landreth
tony-landreth reviewed May 7, 2025
View reviewed changes
tony-landreth
tony-landreth reviewed May 7, 2025
View reviewed changes
tony-landreth
tony-landreth reviewed May 7, 2025
View reviewed changes
tony-landreth
tony-landreth reviewed May 7, 2025
View reviewed changes
benjaminjb and others added 8 commits May 7, 2025 16:05
@benjaminjb
Add pg_hba checksum metric
2d357f3 
We want OTel metrics to be as close to parity with
the postgres_exporter solution as possible; so this
PR adds the initial setup and metric query to get
'ccp_pg_hba_checksum', as well as the util function
to mark a pg_hba setting as valid.

Issues: [PGO-2395]
@benjaminjb
update test
f0b9881
@benjaminjb
fix comment
c235146
@benjaminjb @tony-landreth
Update internal/collector/postgres_5m_metrics.yaml
1c1ba51 
Co-authored-by: Tony Landreth <[email protected]>
@benjaminjb @tony-landreth
Update internal/controller/postgrescluster/metrics_setup.sql
216f2b7 
Co-authored-by: Tony Landreth <[email protected]>
@benjaminjb
fix:
4c534cf
@benjaminjb
comments, rework pg_hba func
8167a63
@benjaminjb
comments, rework pg_hba func
dc25f7b
@benjaminjb benjaminjb force-pushed the benjb/otel-hba-checksum branch from 41be6fc to dc25f7b Compare May 7, 2025 21:10
tony-landreth
tony-landreth approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@tony-landreth tony-landreth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@benjaminjb benjaminjb merged commit 1fa4ba4 into CrunchyData:main May 8, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-landreth tony-landreth tony-landreth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminjb @tony-landreth