Skip to content

Adds ccp_settings_gauge to OTel metrics #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tony-landreth
Copy link
Contributor

This commit adds the folowing metrics:

  • ccp_settings_gauge_checkpoint_timeout
  • ccp_settings_gauge_checkpoint_completion_target
  • ccp_settings_gauge_shared_buffers

These metrics have been supported for PGO on
postgres_exporter. They are now supported for
PGO on OpenTelemetry.

Issue: PGO-2473

This commit adds the folowing metrics:
- ccp_settings_gauge_checkpoint_timeout
- ccp_settings_gauge_checkpoint_completion_target
- ccp_settings_gauge_shared_buffers

These metrics have been supported for PGO on
postgres_exporter. They are now supported for
PGO on OpenTelemetry.

Issue: PGO-2473
Comment on lines +64 to +65
static_attributes:
server: "localhost:5432"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me what we add this for?

Copy link
Contributor Author

@tony-landreth tony-landreth May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We include this bit to maintain parity with postgres-exporter metrics. It gives us the server label, ex.:

ccp_settings_gauge_checkpoint_completion_target{server="localhost:5432"} 0.9

Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is straight from pgMonitor, right? Do they have differences over different PG versions?

@tony-landreth
Copy link
Contributor Author

This is straight from pgMonitor, right? Do they have differences over different PG versions?

That's right. There's only one version. I don't think pgMonitor actually supports these metrics.

@tony-landreth
Copy link
Contributor Author

We've decided against including these metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants