Adds ccp_settings_gauge to OTel metrics #4171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the folowing metrics: - ccp_settings_gauge_checkpoint_timeout - ccp_settings_gauge_checkpoint_completion_target - ccp_settings_gauge_shared_buffers These metrics have been supported for PGO on postgres_exporter. They are now supported for PGO on OpenTelemetry. Issue: PGO-2473
benjaminjb
reviewed
May 7, 2025
Comment on lines
+64
to
+65
| static_attributes: | ||
| server: "localhost:5432" |
There was a problem hiding this comment.
Can you remind me what we add this for?
There was a problem hiding this comment.
We include this bit to maintain parity with postgres-exporter metrics. It gives us the server label, ex.:
ccp_settings_gauge_checkpoint_completion_target{server="localhost:5432"} 0.9
benjaminjb
reviewed
May 7, 2025
That's right. There's only one version. I don't think pgMonitor actually supports these metrics. |
benjaminjb
approved these changes
May 7, 2025
|
We've decided against including these metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the folowing metrics:
These metrics have been supported for PGO on
postgres_exporter. They are now supported for
PGO on OpenTelemetry.
Issue: PGO-2473