Skip to content

Remove Snapshot Flakes#4176

Merged
andrewlecuyer merged 1 commit intoCrunchyData:mainfrom
andrewlecuyer:snapshot-flake
May 21, 2025
Merged

Remove Snapshot Flakes#4176
andrewlecuyer merged 1 commit intoCrunchyData:mainfrom
andrewlecuyer:snapshot-flake

Conversation

@andrewlecuyer
Copy link
Copy Markdown
Collaborator

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

Snapshot tests often fail during envtest-existing test runs, since test and the Job controller are both trying to write to the Job status.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Snapshot tests are skipped during envtest-existing test runs.

Other Information:

@andrewlecuyer andrewlecuyer requested a review from dsessler7 May 9, 2025 21:36
Copy link
Copy Markdown
Collaborator

@dsessler7 dsessler7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlecuyer andrewlecuyer merged commit 24f0325 into CrunchyData:main May 21, 2025
12 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants