fixed incorrect conversion of the X.509 serial number ASN1_INTEGER field#139
Closed
Shaeto wants to merge 2 commits intoDCMTK:masterfrom
Closed
fixed incorrect conversion of the X.509 serial number ASN1_INTEGER field#139Shaeto wants to merge 2 commits intoDCMTK:masterfrom
Shaeto wants to merge 2 commits intoDCMTK:masterfrom
Conversation
michaelonken
reviewed
Jan 8, 2026
| char certSubjectName[1024]; /* certificate subject name (DN) */ | ||
| char certIssuerName[1024]; /* certificate issuer name (DN) */ | ||
| const char *certPubKeyType = "unknown"; /* certificate public key type */ | ||
| OFString certPubKeyType = "unknown"; /* certificate public key type */ |
Member
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Potential hardcoded credential detected. This code may contain sensitive data such as passwords or API keys embedded directly in the source. Hardcoded credentials can be extracted and misused, leading to unauthorized access to systems or data breaches. To remediate this, store secrets in environment variables or use a secrets management tool like AWS Secrets Manager, Azure Key Vault, or HashiCorp Vault. Avoid committing credentials to version control. For best practices, refer to - https://cwe.mitre.org/data/definitions/798.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description is available here https://forum.dcmtk.org/viewtopic.php?t=5494