Skip to content

IMTA-19310: Simplified parent relationships - #42

Open
manicminer wants to merge 1 commit into
mainfrom
feature/IMTA-19310-parents-all-the-way
Open

IMTA-19310: Simplified parent relationships#42
manicminer wants to merge 1 commit into
mainfrom
feature/IMTA-19310-parents-all-the-way

Conversation

@manicminer

Copy link
Copy Markdown
Member

Note

This pull request was migrated from GitLab

Original Author @DannyJo
GitLab Project imports/spring-boot-common
GitLab Merge Request IMTA-19310: Simplified parent relationsh...
GitLab MR Number 76
Date Originally Opened Wed, 5 Feb 2025
Approved on GitLab by No approvers

Original Description

Local testing on permissions service has it's pom look like this

  <parent>
    <groupId>uk.gov.defra.tracesx</groupId>
    <artifactId>TracesX-SpringBoot-Common-Parent</artifactId>
    <version>4.0.7-SNAPSHOT</version>
  </parent>

  <dependencies>
    <dependency>
      <groupId>uk.gov.defra.tracesx</groupId>
      <artifactId>TracesX-SpringBoot-Common-Health</artifactId>
    </dependency>
    <dependency>
      <groupId>uk.gov.defra.tracesx</groupId>
      <artifactId>TracesX-SpringBoot-Common-Security</artifactId>
    </dependency>
    <dependency>
      <groupId>uk.gov.defra.tracesx</groupId>
      <artifactId>TracesX-SpringBoot-Common-Logging</artifactId>
    </dependency>
    <dependency>
      <groupId>org.assertj</groupId>
      <artifactId>assertj-core</artifactId>
      <scope>test</scope>
    </dependency>
    <dependency>
      <groupId>com.github.erosb</groupId>
      <artifactId>everit-json-schema</artifactId>
    </dependency>
    <dependency>
      <groupId>org.json</groupId>
      <artifactId>json</artifactId>
    </dependency>
  </dependencies>

@manicminer

Copy link
Copy Markdown
Member Author

Note

This comment was migrated from GitLab

Original Author @crosslandwa
Note ID 360619
Date Originally Created Wed, 5 Feb 2025

Original Comment

this will change the "parent chain"

currently we have

app > TracesX-SpringBoot-Common-Parent > spring-boot-starter-parent > spring-boot-dependencies

and with this change in place it would become

app > TracesX-SpringBoot-Common-Parent > TracesX-SpringBoot-Common > spring-boot-dependencies

which misses out spring-boot-starter-parent (which adds build stuff around handling of src/main/resources)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant