Try to make Core be more modern per c++20 #5625
Open
+129
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::ranges::end() iterator.
Contributor
Author
|
I tested most of this. Ought to have tests for all the commands. Manual checking sucks. The keybinding commands work as expected with std::views::drop and std::views::reverse. |
Contributor
Author
|
Alright, for the most part, I only did the stuff I could verify, so I guess that's it for now. I added a couple of utility functions to miscutil.h for replacing backslashes to forward slashes. Didn't use ranges there to avoid adding another include. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are definitely parts that need some refactoring, I think.
The intent was not to change any behavior or risk changing behavior, so refactoring was kept to minimum.