various 1.21.3 compatibility fixes #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixes a disconnect with the phaser
Merged
Contributor
Author
|
resolved the requested changes, here are the changes made: [Additions]
[Changes]
[Fixes]
|
RedVortexDev
requested changes
Nov 19, 2024
Member
RedVortexDev
left a comment
RedVortexDev
left a comment
There was a problem hiding this comment.
a bit about command queue
src/main/java/dev/dfonline/codeclient/command/CommandSender.java
Outdated
Show resolved
Hide resolved
RedVortexDev
approved these changes
Nov 19, 2024
Member
RedVortexDev
left a comment
RedVortexDev
left a comment
There was a problem hiding this comment.
LGTM, merging to 1.21 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running the client seems stable and no glaring issues are obvious to me anymore.
however, i did notice that the
DestroyItemResetconfig option wasn't saving and I wasn't able to fix this issue.[Changes]
/ptp [x] [y] [z] [pitch] [yaw](originally this was supposed to fix a disconnect when using the feature, but the issue was unrelated and has been fixed)[Fixes]
spaceandnewlinetags were affecting the chat bar in negative ways.