Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minecraft-version): Add English to extension #18374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dmytrohoi
Copy link

Example for the Proposed Route(s) / 路由地址示例

NOROUTE

Note / 说明

Add English language parameter to Minecraft Version extension. Set en as default as it described in manifest.

This pull request includes changes to add language support and improve internationalization for the Minecraft version route. The most important changes include adding a new language parameter, updating descriptions, and implementing internationalization for version types and titles.

Language support:

Internationalization:

  • lib/routes/minecraft/version.ts: Updated the description section to include both English and Chinese translations for version types and link types.
  • lib/routes/minecraft/version.ts: Introduced an i18n object to handle internationalized strings for version types, titles, and updates in both English and Chinese.
  • lib/routes/minecraft/version.ts: Modified the handler function to use the i18n object for generating titles and descriptions based on the selected language.

@github-actions github-actions bot added the Route label Feb 17, 2025
@dmytrohoi dmytrohoi changed the title feature/minecraft-version - Add English to extension feat(minecraft-version): Add English to extension Feb 17, 2025
@github-actions github-actions bot added the Auto: Route Test Skipped PR involves no routes label Feb 17, 2025
Copy link
Collaborator

@TonyRL TonyRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the route test was intentionally skipped, it's impossible to determine whether the intended changes work or not.

categories: ['game'],
example: '/minecraft/version',
example: '/minecraft/version/all/official/en',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the example, does this PR break the current example?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially, in manifest was declared that language of plugin it's "en", and in this PR it was implemented. Example updated with all default fields for route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants