feat(route/jlu): add CSW (Software College) jbtz and xbtz notificatio…#22088
Open
Rito-492 wants to merge 1 commit into
Open
feat(route/jlu): add CSW (Software College) jbtz and xbtz notificatio…#22088Rito-492 wants to merge 1 commit into
Rito-492 wants to merge 1 commit into
Conversation
…n routes Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
Bot
added
route
auto: not ready to review
Contributor
|
Successfully generated as following: http://localhost:1200/jlu/csw/jbtz - Failed ❌http://localhost:1200/jlu/csw/xbtz - Failed ❌ |
TonyRL
reviewed
Jun 2, 2026
| import got from '@/utils/got'; | ||
|
|
||
| export const route: Route = { | ||
| path: '/csw/:category', |
Collaborator
There was a problem hiding this comment.
Missing parameter description for category
| source: ['csw.jlu.edu.cn/index/jbtz.htm', 'csw.jlu.edu.cn/index/xbtz.htm'], | ||
| }, | ||
| ], | ||
| name: '吉林大学软件学院 - 通知公告', |
Collaborator
There was a problem hiding this comment.
Do not include namespace name
RSSHub/lib/routes/jlu/namespace.ts
Line 4 in 25e88bf
|
|
||
| return { | ||
| title: `吉林大学软件学院 - ${titleSuffix}`, | ||
| link: baseUrl, |
Collaborator
There was a problem hiding this comment.
Use
RSSHub/lib/routes/jlu/csw/index.ts
Line 24 in 25e88bf
| const el = $(item); | ||
| const linkEl = el.find('.title a'); | ||
| const dateStr = el.find('.time').text().trim(); | ||
| const title = linkEl.text().trim(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const title = linkEl.text().trim(); | |
| const title = linkEl.attr('title'); |
.text() is truncated.
| const dateStr = el.find('.time').text().trim(); | ||
| const title = linkEl.text().trim(); | ||
| const rawLink = linkEl.attr('href')!.replaceAll('..', ''); | ||
| const link = `${baseUrl}${encodeURI(rawLink)}`; |
Collaborator
There was a problem hiding this comment.
I don't think those alphabets, numbers, / and . require encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n routes
Involved Issue / 该 PR 相关 Issue
Close #
Example for the Proposed Route(s) / 路由地址示例
New RSS Route Checklist / 新 RSS 路由检查表
PuppeteerNote / 说明