feat(core): add content_html and content_text fallbacks for all feed formats - #22852
Open
gosxrgxx wants to merge 3 commits into
Open
feat(core): add content_html and content_text fallbacks for all feed formats#22852gosxrgxx wants to merge 3 commits into
gosxrgxx wants to merge 3 commits into
Conversation
Contributor
Auto ReviewThis PR only touches core view files (no route scripts), so the route-metadata rules in Consistency
Correctness / middleware coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Involved Issue / 该 PR 相关 Issue
Close #
Example for the Proposed Route(s) / 路由地址示例
New RSS Route Checklist / 新 RSS 路由检查表
PuppeteerNote / 说明
Atom
Atom, like JSON Feed, supports
content.text(via thetype="text"attribute), but unlike JSON Feed, the Atom element (atom:entry) must not contain more than onecontentelement.Therefore, a condition was added for Atom where
contentwith thetype="text"attribute acts as a fallback ifcontent.htmlis missing.If
contentis empty, it must contain a link (item.link) to the content in thesrcattribute.RSS
Also,
content.htmlandcontent.textwere added as fallbacks for RSS 2.0. This removes the need to include adescriptionwhen creating new routes, allowing the use of clearer options likecontent.htmlandcontent.text. At the same time, this keeps backward compatibility with old routes.JSON Feed
item.titlemust be rendered incontent_htmlonly ifcontent.textis not provided, to prevent getting the text content incontent_textand the title incontent_html. Also, sinceitem.titleis text content, it must be a fallback forcontent_textinstead ofcontent_html.