Skip to content

[ros_introspection] Fix NoneType error in remove_element#92

Open
IamPhytan wants to merge 1 commit intoDLu:mainfrom
IamPhytan:parent-node
Open

[ros_introspection] Fix NoneType error in remove_element#92
IamPhytan wants to merge 1 commit intoDLu:mainfrom
IamPhytan:parent-node

Conversation

@IamPhytan
Copy link

ROS Distro : melodic, noetic

I had the following error when trying to run magical_ros2_conversion_tool :

AttributeError: 'NoneType' object has no attribute 'childNodes'

This happened when the tool was removing deprecated dependencies like tf and roscpp from package.xml. I'm not exactly sure why the DOM Element has no parent node when they refer to deprecated dependencies, but my fix avoids removing elements when those Elements have no parentNode.

@DLu
Copy link
Owner

DLu commented Nov 14, 2022

Are you able to share the package.xml?

@IamPhytan
Copy link
Author

Yes, I can share the package.xml. You can find it here. Or you can also try another package.xml from the same repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments