Skip to content

Some bug fixes and a docker container to simplify usage#95

Open
Mat198 wants to merge 6 commits intoDLu:mainfrom
Mat198:main
Open

Some bug fixes and a docker container to simplify usage#95
Mat198 wants to merge 6 commits intoDLu:mainfrom
Mat198:main

Conversation

@Mat198
Copy link

@Mat198 Mat198 commented Jun 13, 2025

Bugs I found while I was trying this tool:

  • Crash during package.xml convertion when an element had a None parent
  • Missing python dependencies
  • Missing file rviz_class_defaults.yaml wich was not installed

Docker to use the tool without having ROS 1 and other dependencies installed

@Mat198
Copy link
Author

Mat198 commented Jun 13, 2025

It seens that the build is failing due to this: https://discourse.ros.org/t/ros-signing-key-migration-guide/43937

Is it possible to update the test docker?

16:05:37  ---> Running in 8ca6a326b46c
16:05:37 2025-06-13 (-0800)
16:05:37 Removing intermediate container 8ca6a326b46c
16:05:37  ---> 4820faa1a8cb
16:05:37 Step 19/27 : RUN for i in 1 2 3; do apt-get update && apt-get install -q -y python3 && apt-get clean && break || if [ $i -lt 3 ]; then sleep 5; else false; fi; done
16:05:37  ---> Running in 43ce0c1158ab
16:05:37 Get:1 http://repositories.ros.org/ubuntu/testing focal InRelease [4,679 B]
16:05:37 Err:1 http://repositories.ros.org/ubuntu/testing focal InRelease
16:05:37   The following signatures were invalid: EXPKEYSIG F42ED6FBAB17C654 Open Robotics <info@osrfoundation.org>
16:05:37 Hit:2 http://security.ubuntu.com/ubuntu focal-security InRelease
16:05:38 Hit:3 http://archive.ubuntu.com/ubuntu focal InRelease
16:05:38 Hit:4 http://archive.ubuntu.com/ubuntu focal-updates InRelease
16:05:38 Hit:5 http://archive.ubuntu.com/ubuntu focal-backports InRelease
16:05:38 Reading package lists...
16:05:39 �[91mW: GPG error: http://repositories.ros.org/ubuntu/testing focal InRelease: The following signatures were invalid: EXPKEYSIG F42ED6FBAB17C654 Open Robotics <info@osrfoundation.org>
16:05:39 E: The repository 'http://repositories.ros.org/ubuntu/testing focal InRelease' is not signed.
16:05:39 �[0mGet:1 http://repositories.ros.org/ubuntu/testing focal InRelease [4,679 B]
16:05:44 Err:1 http://repositories.ros.org/ubuntu/testing focal InRelease
16:05:44   The following signatures were invalid: EXPKEYSIG F42ED6FBAB17C654 Open Robotics <info@osrfoundation.org>
16:05:44 Hit:2 http://security.ubuntu.com/ubuntu focal-security InRelease
16:05:44 Hit:3 http://archive.ubuntu.com/ubuntu focal InRelease
16:05:44 Hit:4 http://archive.ubuntu.com/ubuntu focal-updates InRelease
16:05:45 Hit:5 http://archive.ubuntu.com/ubuntu focal-backports InRelease
16:05:45 Reading package lists...
16:05:46 �[91mW: GPG error: http://repositories.ros.org/ubuntu/testing focal InRelease: The following signatures were invalid: EXPKEYSIG F42ED6FBAB17C654 Open Robotics <info@osrfoundation.org>
16:05:46 E: The repository 'http://repositories.ros.org/ubuntu/testing focal InRelease' is not signed.
16:05:46 �[0mGet:1 http://repositories.ros.org/ubuntu/testing focal InRelease [4,679 B]
16:05:51 Err:1 http://repositories.ros.org/ubuntu/testing focal InRelease
16:05:51   The following signatures were invalid: EXPKEYSIG F42ED6FBAB17C654 Open Robotics <info@osrfoundation.org>
16:05:51 Hit:2 http://archive.ubuntu.com/ubuntu focal InRelease
16:05:51 Hit:3 http://archive.ubuntu.com/ubuntu focal-updates InRelease
16:05:51 Hit:4 http://security.ubuntu.com/ubuntu focal-security InRelease
16:05:51 Hit:5 http://archive.ubuntu.com/ubuntu focal-backports InRelease
16:05:51 Reading package lists...
16:05:52 �[91mW: GPG error: http://repositories.ros.org/ubuntu/testing focal InRelease: The following signatures were invalid: EXPKEYSIG F42ED6FBAB17C654 Open Robotics <info@osrfoundation.org>
16:05:52 E: The repository 'http://repositories.ros.org/ubuntu/testing focal InRelease' is not signed.
16:05:52 �[0mRemoving intermediate container 43ce0c1158ab
16:05:52 The command '/bin/sh -c for i in 1 2 3; do apt-get update && apt-get install -q -y python3 && apt-get clean && break || if [ $i -lt 3 ]; then sleep 5; else false; fi; done' returned a non-zero code: 1
16:05:52 Build step 'Execute shell' marked build as failure
16:05:52 [CMakeGNU C Compiler (gcc)Clang-Tidy] Skipping execution of recorder since overall result is 'FAILURE'
16:05:52 INFO: Processing GoogleTest-1.8
16:05:52 INFO: [GoogleTest-1.8] - No test report file(s) were found with the pattern 'ws/test_results/**/*.xml' relative to '/home/jenkins-agent/workspace/Npr__roscompile__ubuntu_focal_amd64' for the testing framework 'GoogleTest-1.8'.
16:05:52 Did you enter a pattern relative to (and within) the workspace directory?
16:05:52 Did you generate the result report(s) for 'GoogleTest-1.8'?"
16:05:52 WARNING: All test reports are empty.
16:05:52 INFO: Check 'Failed Tests' threshold.
16:05:52 INFO: Check 'Skipped Tests' threshold.
16:05:52 INFO: Setting the build status to FAILURE
16:05:52 Setting status of 0d945499f1198564d56e329d6dc4e0a5a734e648 to FAILURE with url https://build.ros.org/job/Npr__roscompile__ubuntu_focal_amd64/30/ and message: 'Build finished. '
16:05:52 Using context: Npr__roscompile__ubuntu_focal_amd64
16:05:53 Finished: FAILURE```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments