Update the chunk capabilities while setting data for a connection #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Capabilities test cases (Section 2.4):
Requester → GET_CAPABILITIES
{ SPDMVersion = NegotiatedVersion, Flags &= ~CHUNK_CAP, DataTransferSize ≠ MaxSPDMmsgSize }
Condition: NegotiatedVersion ≥ 1.2
The CHUNK_CAP flag is not set when configuring the connection. Later, during connection initialization in the test cases, the function libspdm_mask_capability_flags() is invoked, which applies a logical AND (&&) to the capability flags based on the negotiated version and existing flags.
Additionally, during initialization, the values of "data_transfer_size" and "max_spdm_msg_size" are not equal. This mismatch causes the responder to fail consistently, resulting in the test cases being skipped.
Failure:
test assertion 3.2.0 - NOT_TESTED case_setup_func fail
test assertion 3.4.0 - NOT_TESTED case_setup_func fail
test assertion 3.6.0 - NOT_TESTED case_setup_func fail
test assertion 3.7.0 - NOT_TESTED case_setup_func fail
test assertion 4.1.0 - NOT_TESTED case_setup_func fail
test assertion 4.2.0 - NOT_TESTED case_setup_func fail
test assertion 5.1.0 - NOT_TESTED case_setup_func fail
test assertion 5.2.0 - NOT_TESTED case_setup_func fail
@steven-bellock and @jyao1, please check this PR changes.