Skip to content

Conversation

@jyao1
Copy link
Member

@jyao1 jyao1 commented Jul 25, 2025

This is based on https://github.com/steven-bellock/libspdm/tree/fix-3108, and add One-by-One Measurement Report format.

Ref #3108

@jyao1 jyao1 requested a review from steven-bellock as a code owner July 25, 2025 07:37
@jyao1 jyao1 changed the title Meas report Standard measurement format Jul 25, 2025
Signed-off-by: Steven Bellock <[email protected]>
@jyao1 jyao1 force-pushed the meas_report branch 4 times, most recently from ddf9a5c to 7e459d2 Compare July 25, 2025 10:57
@steven-bellock
Copy link
Contributor

@jyao1 since this is not an official DMTF specification the document should not have normative language like "should", "shall", and "must"; it is a descriptive document. A Verifier's documentation can use normative language if it wants, to specify that this must be followed.

I might be able to discuss this with a wider audience at OCP Security on 29-July-2025. In particular to get feedback on where a document like this should reside, as well as the One-by-One-Measurements Report and buffer sizes.

Rename existing one to Standard All-Measurements Report Definition.

Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
Copy link
Member Author

jyao1 commented Jul 29, 2025

@jyao1 since this is not an official DMTF specification the document should not have normative language like "should", "shall", and "must"; it is a descriptive document. A Verifier's documentation can use normative language if it wants, to specify that this must be followed.

I might be able to discuss this with a wider audience at OCP Security on 29-July-2025. In particular to get feedback on where a document like this should reside, as well as the One-by-One-Measurements Report and buffer sizes.

I changed shall and must to should.
should is weak, it should be OK for a white paper document.

@jyao1 jyao1 added the documentation Improvements or additions to documentation label Sep 22, 2025
As such, the `GET_MEASUREMENTS` with `Param2` 2 and `ERROR` response are NOT included
in the measurement report.
Once the successfully received number of measurement block is `n`-1, the requester should send
the next `GET_MEASUREMENTS` with `SignatureRequested` set.
Copy link
Member

@mcsmonk mcsmonk Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3341 (review)

Under the current logic, an invalid or missing index (e.g., gap in sequence) triggers an error, leading to re-initialization of the L1/L2 transcript — thereby breaking attestation.
(DSP0274 describes that "An error response with any error code other than ResponseNotReady or LargeResponse
shall re-initialize L1/L2 to null".)

Does this cuase a problem in this process?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Also need to check if the Responder-validator assumes this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for 1-by-1, we need two rounds.
Round 1 is to collect valid index.
Round 2 is to collect measurement based on the valid index.

@jyao1
Copy link
Member Author

jyao1 commented Nov 10, 2025

#3341 is the new PR.
This can be closed.

@jyao1 jyao1 closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants