Update multikey flow documentation #3327
Conversation
steven-bellock
added
the
documentation
| associated with. | ||
| - If `MULTI_KEY_CAP == 1` and the Responder supports only one asymmetric cryptography | ||
| algorithm then this step can be performed before the connection is established. | ||
| 3. Calls to `libspdm_responder_data_sign` then specify the `KeyPairID`. |
There was a problem hiding this comment.
I think we need to update requester as well, since we pass KeyPairID to libspdm_requester_data_sign
There was a problem hiding this comment.
That will be done as part of the encapsulated flow documentation cleanup.
There was a problem hiding this comment.
That will be done as part of the encapsulated flow documentation cleanup.
But we are working on multikey here, not encapsulated flow document.
Looking at "Multikey Flow for libspdm Requester" section, it talks nothing about "encapsulated flow". Why mix them?
There was a problem hiding this comment.
Yeah it looks like I can document the multikey encapsulated flow for the Requester side. However it looks like, even ignoring multikey, parts of the encapsulated flow for the Responder side are broken, even on the 3.8 release. I will file an issue for that.
There was a problem hiding this comment.
That is fine. You can work on other encapsulated feature later.
Here, my comment is to document same content between requester and responder.
There was a problem hiding this comment.
The instructions have been updated. I went with "Requester Sign / Responder Verify Flow" instead of "Encapsulated", although ultimately, if the libspdm Requester is going to sign a message using multikey, it needs to set ENCAP_CAP. Let me know if the new document is clear.
steven-bellock
force-pushed
the
update-multikey
branch
from
31d2300 to
2ed764f
Compare
steven-bellock
force-pushed
the
update-multikey
branch
from
2ed764f to
570f38a
Compare
Signed-off-by: Steven Bellock <[email protected]>
steven-bellock
force-pushed
the
update-multikey
branch
from
570f38a to
441e987
Compare
steven-bellock
changed the title
2 participants
This is informed by #3290.