Fix tracking station selecting vessel when terminating mission or sorting the list #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double clicking the sort buttons in the tracking station selects a vessel. Doing it again while that vessel is selected enters flight, but causes a bunch of errors, like the HUD not going away after exiting the flight. This happens in the Default mode if there's more than one vessel, and in Body and Vessel type mode if there's more than one group, for example Kerbin and Duna or Ship and Station. Terminating a mission selects a vessel as well, as it does in vanilla, but the errors are caused by the toggled button being destroyed in the ClearUI method.
I don't know Unity that well, but I think this is because allowSwitchOff is false on the toggle group. Adding an invisible toggle fixes this. I don't know if this is the best way to do it, but I haven't found any problems yet. It also seems to make selecting a vessel work more consistently.