Skip to content

Fixes to API access endpoint and update some exposed properties #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025

Conversation

eldering
Copy link
Member

List all properties (also DOMjudge specific ones) in the access API endpoint, and add endpoints accounts and clarifications there.

Also remove exposing problems.types_to_string and add judgements.current (as alias of valid).

@eldering eldering force-pushed the fix-api-access-endpoint branch 3 times, most recently from df213af to 080f83c Compare July 13, 2025 13:52
@nickygerritsen
Copy link
Member

I already had a local change for current that only exposes it if you enable the new api and removes it from the event feed as well, but if we merge this I can rebase and change my code

@eldering
Copy link
Member Author

I can also remove current from my PR. I guess that's easier for you?

@nickygerritsen
Copy link
Member

I can also remove current from my PR. I guess that's easier for you?

Sure that would work indeed

eldering added 2 commits July 14, 2025 19:33
Don't exactly check for each property as that's just silly
repeating of lists.
@eldering eldering force-pushed the fix-api-access-endpoint branch from 080f83c to 9992568 Compare July 14, 2025 17:33
@eldering
Copy link
Member Author

I can also remove current from my PR. I guess that's easier for you?

Sure that would work indeed

Done.

@eldering eldering added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit 47efe69 Jul 15, 2025
42 checks passed
@eldering eldering deleted the fix-api-access-endpoint branch July 15, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants