-
Notifications
You must be signed in to change notification settings - Fork 49
[DSpace-CRIS] Creation of a custom URL for Items (REST Contract) #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tdonohue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdamF42 : This REST Contract looks good to me except that it needs a minor update since your backend PR is now returning a 404 if the item is not found. Once that change is made, I think this looks good.
items.md
Outdated
|
|
||
| Return codes: | ||
| * 200 OK - if the operation succeed | ||
| * 204 No content - if the operation succeed but no item was found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdamF42 : This needs a minor update as we're now returning a proper 404 if the item is not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching that! I've updated the return code from 204 to 404 to reflect the actual implementation.
Change return code from 204 No content to 404 Not found when no item is found with the given custom URL, reflecting the actual implementation.
tdonohue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @AdamF42 ! This contract update looks good to me now. It can be merged as soon as the backend PR is merged.
Rest contract updates for DSpace/DSpace#11549.