Skip to content

Conversation

@AdamF42
Copy link
Contributor

@AdamF42 AdamF42 commented Nov 18, 2025

Rest contract updates for DSpace/DSpace#11549.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge. DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. labels Dec 1, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Dec 1, 2025
@tdonohue tdonohue self-requested a review December 4, 2025 17:32
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamF42 : This REST Contract looks good to me except that it needs a minor update since your backend PR is now returning a 404 if the item is not found. Once that change is made, I think this looks good.

items.md Outdated

Return codes:
* 200 OK - if the operation succeed
* 204 No content - if the operation succeed but no item was found
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamF42 : This needs a minor update as we're now returning a proper 404 if the item is not found.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that! I've updated the return code from 204 to 404 to reflect the actual implementation.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release Feb 3, 2026
@tdonohue tdonohue changed the title MERGER: porting creation of a custom URL for Items [DSpace-CRIS] Creation of a custom URL for Items (REST Contract) Feb 3, 2026
@tdonohue tdonohue added this to the 10.0 milestone Feb 3, 2026
Change return code from 204 No content to 404 Not found when no item is found with the given custom URL, reflecting the actual implementation.
@AdamF42 AdamF42 requested a review from tdonohue February 4, 2026 14:22
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @AdamF42 ! This contract update looks good to me now. It can be merged as soon as the backend PR is merged.

@github-project-automation github-project-automation bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release Feb 4, 2026
@tdonohue tdonohue merged commit 0e60c5e into DSpace:main Feb 5, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge. DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. new feature

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants