Skip to content

[Port dspace-9_x] Fix: Scrollable dropdown does not highlight current selection (#4958)#5086

Merged
tdonohue merged 1 commit intodspace-9_xfrom
backport-5020-to-dspace-9_x
Feb 6, 2026
Merged

[Port dspace-9_x] Fix: Scrollable dropdown does not highlight current selection (#4958)#5086
tdonohue merged 1 commit intodspace-9_xfrom
backport-5020-to-dspace-9_x

Conversation

@dspace-bot
Copy link
Contributor

Port of #5020 by @solomona2003 to dspace-9_x.

Dynamic Loading:
- Uses actual vocabulary size from pageInfo.totalElements
- Caps at 200 items to prevent loading huge vocabularies
- Performance scaled: 50 items (Good UX), 100 items (Acceptable), 200 items (Borderline)

Selection Highlighting:
- Highlight current value when menu opens (setSelectedIndexToCurrentValue)
- Treat 'Clear selection' as index 0, adjust item indices (i+1)
- Arrow key navigation respects clear item (totalItems)
- Enter selects correct item or clears when index = 0
- Skip disabled items in scrollToSelected
- Selected items now highlighted correctly up to position 200# This is the 1st commit message:

(cherry picked from commit 44a3fcd)
@dspace-bot dspace-bot added 1 APPROVAL pull request only requires a single approval to merge accessibility bug component: submission usability labels Feb 6, 2026
@tdonohue tdonohue moved this to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Feb 6, 2026
@tdonohue tdonohue added this to the 9.3 milestone Feb 6, 2026
@tdonohue tdonohue merged commit 0e0806f into dspace-9_x Feb 6, 2026
16 checks passed
@tdonohue tdonohue deleted the backport-5020-to-dspace-9_x branch February 6, 2026 17:06
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge accessibility bug component: submission usability

Projects

Development

Successfully merging this pull request may close these issues.

3 participants