Skip to content

backport DSpace 8: Improve community list e2e tests#5093

Open
oscar-escire wants to merge 1 commit intoDSpace:dspace-8_xfrom
oscar-escire:Issue/3989-dspace-8_x
Open

backport DSpace 8: Improve community list e2e tests#5093
oscar-escire wants to merge 1 commit intoDSpace:dspace-8_xfrom
oscar-escire:Issue/3989-dspace-8_x

Conversation

@oscar-escire
Copy link
Contributor

References

Description

This PR enable 4 new tests to testing community list page functions and elements.

Instructions for Reviewers

  1. Start dspace in development mode
  2. Open cypress testing tool
  3. Click on community-list tests
  4. There will be 4 new tests additional to existing accessibility tests

List of changes in this PR:

  • Enabled a data-test property in "show more" button of community list page
  • Added the fallowing e2e tests to community-list tests.
    • Validate the expansion of community/collection hierarchy
    • Validate correct display of community/collection name and counter
    • If 20 top-communities are present, the button "show more" must be present, otherwise, not will be rendered
    • If 20 top-communities are present and the button "show more" is clicked, after it there will be at least 21 top-communities

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@oscar-escire
Copy link
Contributor Author

Hi @tdonohue, I know it's been a while since I made this pull request, but here's the manual backport for DSpace 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant