Skip to content

Update callback signatures #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eflumerf wants to merge 4 commits into from
Closed

Update callback signatures #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ccb0b9
Update callback signatures
eflumerf Dec 3, 2025
6a28ca5
Merge remote-tracking branch 'origin/develop' into eflumerf/DirectCal…
eflumerf Dec 9, 2025
f67e1fd
Merge branch 'develop' into eflumerf/DirectCallback_QueueConfig
eflumerf Dec 29, 2025
dd8a6c0
Merge branch 'develop' into eflumerf/DirectCallback_QueueConfig
eflumerf Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/FakeDataProdModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ FakeDataProdModule::do_timesync(std::atomic<bool>& running_flag)
}

void
FakeDataProdModule::process_data_request(dfmessages::DataRequest& data_request)
FakeDataProdModule::process_data_request(dfmessages::DataRequest&& data_request)
{

TLOG_DEBUG(TLVL_ENTER_EXIT_METHODS) << get_name() << ": processsing request " << data_request.request_number;
Expand Down
2 changes: 1 addition & 1 deletion plugins/FakeDataProdModule.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class FakeDataProdModule : public dunedaq::appfwk::DAQModule

// Threading
dunedaq::utilities::WorkerThread m_timesync_thread;
void process_data_request(dfmessages::DataRequest&);
void process_data_request(dfmessages::DataRequest&&);
void do_timesync(std::atomic<bool>&);

// Configuration
Expand Down
4 changes: 2 additions & 2 deletions plugins/FragmentAggregatorModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ FragmentAggregatorModule::do_stop(const CommandData_t& /* args */)
}

void
FragmentAggregatorModule::process_data_request(dfmessages::DataRequest& data_request)
FragmentAggregatorModule::process_data_request(dfmessages::DataRequest&& data_request)
{

{
Expand Down Expand Up @@ -206,7 +206,7 @@ FragmentAggregatorModule::process_data_request(dfmessages::DataRequest& data_req
}

void
FragmentAggregatorModule::process_fragment(std::unique_ptr<daqdataformats::Fragment>& fragment)
FragmentAggregatorModule::process_fragment(std::unique_ptr<daqdataformats::Fragment>&& fragment)
{
// Forward Fragment to the right TRB
std::string trb_identifier;
Expand Down
4 changes: 2 additions & 2 deletions plugins/FragmentAggregatorModule.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ class FragmentAggregatorModule : public dunedaq::appfwk::DAQModule
void do_start(const CommandData_t& obj);
void do_stop(const CommandData_t& obj);

void process_data_request(dfmessages::DataRequest&);
void process_fragment(std::unique_ptr<daqdataformats::Fragment>&);
void process_data_request(dfmessages::DataRequest&&);
void process_fragment(std::unique_ptr<daqdataformats::Fragment>&&);

// Input and Output Connection names
std::string m_data_req_input;
Expand Down
6 changes: 3 additions & 3 deletions plugins/TRBModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ TRBModule::do_stop(const CommandData_t& /*args*/)
}

void
TRBModule::tr_requested(const dfmessages::TRMonRequest& req)
TRBModule::tr_requested(const dfmessages::TRMonRequest&& req)
{
++m_trmon_request_counter;

Expand Down Expand Up @@ -328,7 +328,7 @@ TRBModule::flush_trigger_records()
} // NOLINT(readability/fn_size)

void
TRBModule::fragments_callback(std::unique_ptr<daqdataformats::Fragment>& temp_fragment)
TRBModule::fragments_callback(std::unique_ptr<daqdataformats::Fragment>&& temp_fragment)
{

auto start_time = std::chrono::steady_clock::now();
Expand Down Expand Up @@ -428,7 +428,7 @@ TRBModule::fragments_callback(std::unique_ptr<daqdataformats::Fragment>& temp_fr
}

void
TRBModule::trigger_decision_callback(dfmessages::TriggerDecision& td)
TRBModule::trigger_decision_callback(dfmessages::TriggerDecision&& td)
{

auto start_time = std::chrono::steady_clock::now();
Expand Down
6 changes: 3 additions & 3 deletions plugins/TRBModule.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ class TRBModule : public dunedaq::appfwk::DAQModule
using trigger_record_ptr_t = std::unique_ptr<daqdataformats::TriggerRecord>;
using trigger_record_sender_t = iomanager::SenderConcept<trigger_record_ptr_t>;

void trigger_decision_callback(dfmessages::TriggerDecision& td);
void fragments_callback(std::unique_ptr<daqdataformats::Fragment>& frag);
void trigger_decision_callback(dfmessages::TriggerDecision&& td);
void fragments_callback(std::unique_ptr<daqdataformats::Fragment>&& frag);

trigger_record_ptr_t extract_trigger_record(const TriggerId&);
// build_trigger_record will allocate memory and then orphan it to the caller
Expand Down Expand Up @@ -224,7 +224,7 @@ class TRBModule : public dunedaq::appfwk::DAQModule
void do_stop(const CommandData_t&);

// Monitoring callback
void tr_requested(const dfmessages::TRMonRequest &);
void tr_requested(const dfmessages::TRMonRequest &&);

// Threading
std::atomic<bool> m_stop_requested;
Expand Down