Overriding the root controller and local connectivity service addresses#735
Closed
PawelPlesniak wants to merge 76 commits intoprep-release/fddaq-v5.5.0from
Closed
Overriding the root controller and local connectivity service addresses#735PawelPlesniak wants to merge 76 commits intoprep-release/fddaq-v5.5.0from
PawelPlesniak wants to merge 76 commits intoprep-release/fddaq-v5.5.0from
Conversation
… is called twice.
extension to grpc testing tools add shell-based ssh lifetime manager which fits existing tests
…was causing formatting errors in the log files
…e_status recompute_status: single responsibility principle (recompute, don't get)
…aviour Aurashk/fix optional pytest behaviour
…peated replace deprecated method
Add Github Wiki pages to documentation on GithubPages
…ithub-pages-is-failing Fix failing docs deployment to GitHub pages
…anager Aurashk/recompose ssh process manager
Add daqpytools to drunc (v2)
Collaborator
Author
|
This has now also been tested cross process manager implementation - starting with a k8s pm and starting a ssh pm after with the same config file through unified shell |
Contributor
|
Tested with both SSH and K8s process managers; works correctly. |
added 3 commits
December 8, 2025 14:23
Collaborator
Author
|
Merging in develop was a mistake if this is to be for 5.5.0, superseeded with #738 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #702
Changelog
Adds checks to validate that when multiple users are running on the same host, you get an error if trying to use a session that already exists.
Manual testing suggestions
Start a session as
Then in a separate tty try to run the exact same command. You should get log message
When you execute this, the local connectivity service address is still in use, therefore the second time you attempt to run it after you use the suggested script, you will get
Alternative for manual tests include varying the process manager type, and running one session with a local connectivity service and another with the ehn1 connectivity service.
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))