Remaining dedicated grpc messages refactor

[jamesturner246]

Description

Resolves #686.

Refactors the remaining controller fns: take_control, submit_control, who_is_in_control, to_error, and gives them their own message types.

Also remove a whole lot of the older code.

Type of change

• Documentation (non-breaking change that adds or improves the documentation)
• New feature (non-breaking change which adds functionality)
• Optimization (non-breaking, back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

Key checklist

• All tests pass (eg. python -m pytest)
• Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added or an issue has been opened to tackle that in the future.
  (Indicate issue here: # (issue))

[PawelPlesniak]

Hi James, thank you for this PR, having commands addressed correctly is great! Few requests
When running surrender-control, could we have an info log message of

User <username> has surrendered control of session <session id>

Could we similarly have a warning log message of

User <username> is not in control of session <session id>

when running the following?

drunc-unified-shell > surrender-control
drunc-unified-shell > surrender-control
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
        status = StatusCode.INTERNAL
        details = "Exception deserializing response!"
        debug_error_string = "None"
>

Can we also have similar log messages for the following

drunc-unified-shell > take-control
drunc-unified-shell > take-control

I will also define user stories on how we define error states - manually setting an application into error and attempting to get out of it using recompute-status currently does not remove the error state

[jamesturner246]

Thanks for the review @PawelPlesniak. Would it be okay if I made these changes in another PR later? I'm basically at a point where the UI deployment is working, and would be nice to be able to give a demo on Monday with all the new stuff added.

[PawelPlesniak]

This sounds good, thank you for the hard work on the UI deployment! Looking forward to the demo :)

[jamesturner246]

Rebased and full integration testsuite ran on np04. Ready to merge whenever!

I forget -- which channel is PR merges announced on again?

[PawelPlesniak]

This is on #dunedaq-integration

[jamesturner246]

@PawelPlesniak For some reason my access to that channel has been revoked.

[jamesturner246]

Also I'll need an accepting review to merge,.

[PawelPlesniak]

LGTM, passed manual tests

[PawelPlesniak]

I have sent off some requests to find out twho the Slack workspace admin is, to add you Aurash and Miruna to the channel. For today, I will pass on the message so we can get this merged, but I will be contacting the relevant people so I am not the bottleneck