Conversation
|
Note - this has not been marked as "Ready for review" as the archiecture behind the integration tests that start the LCS separately has not yet been understood, hence all integration tests that start their own LCS fail. This will be corrected, but until then, this PR is on hold |
|
In one of the Run Control technical meetings, it was decided that the run control will be able to change the port number provided in the configuration, confirmed with @mroda88, this is a high priority item. |
|
Note - this PR is currently in progress as testing with EHN1 configurations fails the root controller address checks |
|
This is now addressed, requires testing only |
|
Integration tests pass |
|
Note - in commit 190fec5, I have removed all log handlers from the root logger, as |
|
When testing, it was found that when without having a set |
Description
Fixes #702
Includes basic checks for the root controller and local connectivity service applications, and points the user to the commands that should be run to address this.
Changelog
Prior to instantiating the stateful node, the unified shell parses out the root controller address and LCS address to validate that they are not yet in use.
NOTE - this command will not work in the case that configuration file has been cloned locally - i.e. if the configuration file lives on CVMFS, this will not work as CVMFS is a read-only path. You would need to clone it to see the difference.
Suggested testing methods
On the same physical host run
then in a separate tty run
This will give you logs such as
Note - if you attempt to use two identital session IDs with the ehn1 conn srv, this will fail as the root controller port gets mapped over, but the "new" session is pointed to the "old" session in the connectivity service storage. The discussion of having an endpoint to check against existing session IDs has been proposed here.
All the integration tests have passed.
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))