Updating PDVD services: ScintPreScale + OpCalibrator

[lpaulucc]

Changing default ScintPreScale in ProtoDUNE-VD from 1 to 0.2 to address problems with memory and ROOT I/O limitations in cosmics simulation.
This PR should not be merged before DUNE/duneopdet#128.

[vpec0]

Shouldn't this property be used in the simulation related tables only, i.e. protodunevd_minimal_simulation_services and protodunevd_simulation_services (which I see inherits from the former)? I am not fluent in how these tables are supposed to be used, but I would think that anything related to sims should go to a sims only table.

[lpaulucc]

True, I don't know why this parameter has been put in other service tables as well, I was thinking maybe there was some complaint when running but I see the PDSP table does not have it. Let me change.

[vpec0]

Thanks, Laura. So does it run? Have you tried to run the standard keepup fhicl on data as well? The one includes @table::protodunevd_reco_services (https://github.com/DUNE/dunesw/blob/7746a323e74f983cac30366551400d99d590578a/fcl/protodunevd/reco/standard_reco_protodunevd_keepup.fcl#L34).

[YoannKermaidic]

If it's for simulation validation, please use

• https://github.com/DUNE/dunesw/blob/feature/ykermaid_update_sim/fcl/protodunevd/reco/standard_reco_stage0_protodunevd_sim.fcl
• https://github.com/DUNE/dunesw/blob/feature/ykermaid_update_sim/fcl/protodunevd/reco/standard_reco_stage1_protodunevd_sim.fcl

It's essentially the same worflow as data but it will run on detsim input file =)

[lpaulucc]

I ran with sim data and it was fine. The keepup should not be affected by this since the only stages where the ScintPreScale is important are g4 and detsim with the digitizer, not daphne
This will replace the need for the fhicl parameter being directly input to the running fhicl in g4 stage (Barnali's PR) and detsim, which I think has not been included but will cause problems if not.

[vpec0]

I was more concerned about the removal of the configuration from the tables related to data processing. I assume it should not be sensitive to it at all. I was just wondering if it was complaining about not having the parameter set.

[vpec0]

This looks good, as long as it does not break the keepup processing.