Skip to content

build with geant4 v4_11_2_p02#130

Merged
wyjang-uta merged 1 commit intoDUNE:developfrom
lgarren:feature/lg_geant4_11
Feb 27, 2026
Merged

build with geant4 v4_11_2_p02#130
wyjang-uta merged 1 commit intoDUNE:developfrom
lgarren:feature/lg_geant4_11

Conversation

@lgarren
Copy link
Collaborator

@lgarren lgarren commented Jan 30, 2026

No description provided.

@FNALbuild
Copy link
Collaborator

@FNALbuild
Copy link
Collaborator

@FNALbuild
Copy link
Collaborator

@FNALbuild
Copy link
Collaborator

@FNALbuild
Copy link
Collaborator

@FNALbuild
Copy link
Collaborator

@FNALbuild
Copy link
Collaborator

@wyjang-uta wyjang-uta requested review from lpaulucc and vpec0 February 17, 2026 19:56
Copy link
Member

@lpaulucc lpaulucc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be ok in removing the legacyLArG4 folder from LibraryBuildTools but we do need the other files. Unfortunately the full optical simulation has not been ported to the new larg4 and we need to keep using legacy for it. So I would request that only the legacyLArG4 folder is removed and the rest of the deleted files remains.

@lgarren
Copy link
Collaborator Author

lgarren commented Feb 18, 2026

@lpaulucc This PR was created to allow testing. I can modify it, but you may prefer to close this and create a new PR that aligns with your needs. You will need to deal with failing unit tests somehow.

@lpaulucc
Copy link
Member

Are we getting the full optical simulation ported to the new larg4? We need to be able to run it from time to time. Do you see any other way to solve the issue?

@lgarren
Copy link
Collaborator Author

lgarren commented Feb 18, 2026

@lpaulucc Anything relying on LegacyLArG4 will no longer work. That has been the plan for quite some time. However, I am not sure what your question means. Perhaps an email to the SciSoft team with more details would help sort this out.

@lpaulucc
Copy link
Member

@aihimmel Do you know if the situation changed, we now have a working full optical sim in the new larg4 and we just need to adapt those fhicls?

@aihimmel
Copy link
Member

I honestly have no idea. I have not done any porting. I can confirm we need to run the full optical simulation somehow, but I can't speak to the details.

@lpaulucc
Copy link
Member

Thank you, @aihimmel. I will contact people from other experiments to find out if they have a solution in place. This issue comes from many years ago and I was unaware of this imminent drop of support.

@tomjunk
Copy link
Member

tomjunk commented Feb 19, 2026

My apologies for not nagging people! I had thought DUNE was not using LegacyLArG4 but had neglected this particular use. In any case, there's an example in the parent directory, https://github.com/DUNE/duneopdet/blob/develop/duneopdet/PhotonPropagation/LibraryBuildTools/protodunehd_buildopticallibrary_grid.fcl and https://github.com/DUNE/duneopdet/blob/develop/duneopdet/PhotonPropagation/LibraryBuildTools/protodunehd_buildopticallibrary_test.fcl for pdhd that looks like it is designed to run with the refactored LArG4. There is additional tooling in the LArG4 subdirectory but presumably this can be adjusted or put back. Looks like the fcls are fairly different between the PDHD one and say the 1x2x6 one in LegacyLArG4.

Erica suggests that if you need to regenerate libraries, there are always old releases to use if it takes time to adapt to the refactored LArG4.

@lpaulucc lpaulucc self-requested a review February 20, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants