Conversation
|
The tests are being triggered in jenkins. |
|
+LArSoft tests OK on slf7 for c14:prof |
|
+LArSoft tests OK on slf7 for e26:prof |
|
-SBND tests failed on slf7 for e26:prof |
|
-ICARUS tests failed on slf7 for e26:prof |
|
-uBooNE tests failed on slf7 for e26:prof |
|
-DUNE tests failed on slf7 for e26:prof |
There was a problem hiding this comment.
I would be ok in removing the legacyLArG4 folder from LibraryBuildTools but we do need the other files. Unfortunately the full optical simulation has not been ported to the new larg4 and we need to keep using legacy for it. So I would request that only the legacyLArG4 folder is removed and the rest of the deleted files remains.
|
@lpaulucc This PR was created to allow testing. I can modify it, but you may prefer to close this and create a new PR that aligns with your needs. You will need to deal with failing unit tests somehow. |
|
Are we getting the full optical simulation ported to the new larg4? We need to be able to run it from time to time. Do you see any other way to solve the issue? |
|
@lpaulucc Anything relying on LegacyLArG4 will no longer work. That has been the plan for quite some time. However, I am not sure what your question means. Perhaps an email to the SciSoft team with more details would help sort this out. |
|
@aihimmel Do you know if the situation changed, we now have a working full optical sim in the new larg4 and we just need to adapt those fhicls? |
|
I honestly have no idea. I have not done any porting. I can confirm we need to run the full optical simulation somehow, but I can't speak to the details. |
|
Thank you, @aihimmel. I will contact people from other experiments to find out if they have a solution in place. This issue comes from many years ago and I was unaware of this imminent drop of support. |
|
My apologies for not nagging people! I had thought DUNE was not using LegacyLArG4 but had neglected this particular use. In any case, there's an example in the parent directory, https://github.com/DUNE/duneopdet/blob/develop/duneopdet/PhotonPropagation/LibraryBuildTools/protodunehd_buildopticallibrary_grid.fcl and https://github.com/DUNE/duneopdet/blob/develop/duneopdet/PhotonPropagation/LibraryBuildTools/protodunehd_buildopticallibrary_test.fcl for pdhd that looks like it is designed to run with the refactored LArG4. There is additional tooling in the LArG4 subdirectory but presumably this can be adjusted or put back. Looks like the fcls are fairly different between the PDHD one and say the 1x2x6 one in LegacyLArG4. Erica suggests that if you need to regenerate libraries, there are always old releases to use if it takes time to adapt to the refactored LArG4. |
No description provided.