Merged
Conversation
mjkramer
force-pushed
the
mjkramer/feature/unix_ts_autocorrect
branch
from
e7c6520 to
09cde40
Compare
Member
Author
|
Before. Note the wrong unix_ts on event 6, thanks to PACMAN 7, whose system clock was apparently out of sync:
After:
|
Member
|
@mjkramer and I discussed offline testing an edge case where the PPS occurs in coincidence with a NTP tick. Matt, any updates there? |
Member
Author
|
That edge case applies to #195, not this one (which should not have any edge cases). I'll follow up in the other PR. |
Member
|
Ah right - my fault! |
krwood
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that sometimes a PACMAN's system clock may fall out-of-sync with NTP time. (E.g. IO group 7 at the beginning of the sandbox.) Currently, an event's unix_ts comes from whatever IO group happened to produce the first packet in the event. If that timestamp is wrong, it causes issues with Mx2 matching. To make the unix_ts assignment more robust, the
autocorrect_unix_tsoption allows all of the PACMEN to "vote" for the unix_ts.