Skip to content

Port proto_nd_flow yaml changes to ndlar_flow yamls#232

Draft
alexbooth92 wants to merge 1 commit intodevelopfrom
feature/abooth-yamls_rms_dset_name
Draft

Port proto_nd_flow yaml changes to ndlar_flow yamls#232
alexbooth92 wants to merge 1 commit intodevelopfrom
feature/abooth-yamls_rms_dset_name

Conversation

@alexbooth92
Copy link
Member

When running the nominal ndlar_flow workflow for NDLAr in develop, Eva Sabater came across the following crash:

~~~ RUN ~~~
Run loop on light/events:
  timestamp_corrector -> wvfm_filt -> wvfm_align -> wvfm_calib -> wvfm_sum -> sipm_hit_finder -> sum_hit_finder -> flash_finder
  0%|          | 0/4 [00:03<?, ?it/s]
Traceback (most recent call last):
  File "/pscratch/sd/d/dunepro/esabater/install/ND_Production/run-ndlar-flow/flow.venv/bin/h5flow", line 6, in <module>
    sys.exit(main())
             ^^^^^^
  File "/pscratch/sd/d/dunepro/esabater/install/ND_Production/run-ndlar-flow/h5flow/h5flow/__init__.py", line 155, in main
    run(**vars(args))
  File "/pscratch/sd/d/dunepro/esabater/install/ND_Production/run-ndlar-flow/h5flow/h5flow/__init__.py", line 118, in run
    manager.run()
  File "/pscratch/sd/d/dunepro/esabater/install/ND_Production/run-ndlar-flow/h5flow/h5flow/core/h5_flow_manager.py", line 241, in run
    stage.run(self.generator.dset_name, chunk, cache)
  File "/pscratch/sd/d/dunepro/esabater/install/ND_Production/run-ndlar-flow/ndlar_flow/src/proto_nd_flow/reco/light/wvfm_calib.py", line 128, in run
    rms_data = cache[self.rms_dset_name].reshape(event_data.shape)
               ~~~~~^^^^^^^^^^^^^^^^^^^^
KeyError: 'light/events/rms'

This PR implements @mjkramer's suggestion for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant