FmpDeviceSmmLib/Flashing.c: migrate MRC cache across capsule updates#296
Closed
filipleple wants to merge 1 commit intocapsules-v2from
Closed
FmpDeviceSmmLib/Flashing.c: migrate MRC cache across capsule updates#296filipleple wants to merge 1 commit intocapsules-v2from
filipleple wants to merge 1 commit intocapsules-v2from
Conversation
MRC cache was being cleared on every capsule update, forcing a full memory retraining cycle on the next boot. This is unnecessary because the cache is versioned by FSP and will be invalidated automatically if the FSP binary changes in the new firmware. Migrate the RW_MRC_CACHE FMAP region the same way ROMHOLE, BOOTSPLASH and SI_GBE are already handled. The region is not offset-sensitive and its absence in either image is non-fatal. Signed-off-by: Filip Lewinski <filip.lewinski@3mdeb.com>
Member
|
A more completion version of this change has been merged as part of #295, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MRC cache was being cleared on every capsule update, forcing a full memory retraining cycle on the next boot. This is unnecessary because the cache is versioned by FSP and will be invalidated automatically if the FSP binary changes in the new firmware.
Migrate the RW_MRC_CACHE FMAP region the same way ROMHOLE, BOOTSPLASH and SI_GBE are already handled. The region is not offset-sensitive and its absence in either image is non-fatal.